Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
This PR fixes a bug in the 51CTO platform integration where users were incorrectly identified as logged in even when they were not. It improves the login detection logic to avoid false positives from
data-uidattributes belonging to other authors and ensures the "Login" link is correctly displayed.Related Issue / 关联 Issue
Closes #37
Type of Change / 更改类型
Changes Made / 更改内容
parseUserInfologic incose/src/platforms/cto51.jsto strictly detect "Not Logged In" states (e.g., checking for "Login" links orisLoginglobal variable).userIdextraction to the header/user profile area to prevent falsely matchingdata-uidfrom the article feed.cose/src/background.jsto allowparseUserInfoto explicitly return{ loggedIn: false }to override default cookie checks.loginUrlto 51CTO configuration.Implementation Details / 实现细节
Key Changes / 主要更改:
html.match(/<a[^>]*>登录<\/a>/)andisLoginvariable.userIdis now more specific to the user profile context, avoiding random images in the content stream.background.jsnow respects an explicitloggedIn: falsereturn from platform parsers.Technical Notes / 技术说明:
data-uidattributes for post authors. The previous regex was too broad, causing the plugin to pick up the first author's ID as the current user's ID when no session headers were present.Testing / 测试
Testing Checklist / 测试清单
Manual Testing Steps / 手动测试步骤
https://blog.51cto.com/.User_123456.Screenshots/Videos / 截图/视频
(Screenshots can be added here)
Reviewer Checklist / 审阅者清单
Additional Notes / 补充说明
The
uidcookie was removed from the check list incto51.jsas it persisted even after logout, causing misleading "logged in" status judgments.