Add print to the case where raw_message is not JSON #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of trying to execute the cross account bot execution that failed from some reason before boto is initialize - need to add error to the output_message and continue other wise it could make exception of variable used before initialize Add new missing policy for sns related to the cloudwatch_create_metric_filter
RavidAtias
reviewed
Aug 8, 2019
local_test2.py
Outdated
| @@ -0,0 +1,65 @@ | |||
|
|
|||
There was a problem hiding this comment.
Please exclude this file
There was a problem hiding this comment.
Why? we should have a reference to local test execution (some customers are using it )
Don't forget that this is an "open source" tool, customers can contribute and build their own bots, and for that, it's good to have local test execution reference
There was a problem hiding this comment.
Ok i see, so if you think this file should be included add comment explaining how to use it, change it name (remove the 2) and remove private data
RavidAtias
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of trying to execute the cross account bot execution that failed from some reason before boto is initialize - need to add error to the output_message and continue other wise it could make exception of variable used before initialize
Add new missing policy for sns related to the cloudwatch_create_metric_filter