Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Python 3.8+ Literal Syntax warning #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MBfromOK wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Python 3.8+ Literal Syntax warning #196

MBfromOK wants to merge 1 commit into from

Conversation

@MBfromOK
Copy link

@MBfromOK MBfromOK commented Aug 20, 2022

No description provided.

@MBfromOK
Copy link
Author

MBfromOK commented Aug 20, 2022 •
edited
Loading

When installing gitsome via apt-get install gitsome on Ubuntu 22.04 LTS the install completes with the following errors:

/usr/lib/python3/dist-packages/gitsome/github.py:792: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  ('/' + language if language is not 'overall' else '') +
/usr/lib/python3/dist-packages/gitsome/lib/html2text/html2text.py:95: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if c is not ' ' and c is not '  ':
/usr/lib/python3/dist-packages/gitsome/lib/html2text/html2text.py:95: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if c is not ' ' and c is not '  ':
/usr/lib/python3/dist-packages/gitsome/lib/html2text/html2text.py:96: SyntaxWarning: "is" with a literal. Did you mean "=="?
  return c is ' '

This fork replaces these literals with their suggested fixes, my only concern is that the return c is ' ' will break or not return what is expected.

@MBfromOK
Copy link
Author

MBfromOK commented Aug 20, 2022

Note: This is a partial duplicate of #182 as this PR will also correct that file.

@mkindahl
Copy link

mkindahl commented Jan 22, 2024

I created a duplicate #206 of this. It shows up this way on my machine:

mats@fury:~$ sudo apt install gitsome
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following NEW packages will be installed:
  gitsome
0 upgraded, 1 newly installed, 0 to remove and 18 not upgraded.
Need to get 105 kB of archives.
After this operation, 691 kB of additional disk space will be used.
Get:1 http://se.archive.ubuntu.com/ubuntu jammy/universe amd64 gitsome all 0.8.0+ds-6ubuntu1 [105 kB]
Fetched 105 kB in 0s (814 kB/s)   
Selecting previously unselected package gitsome.
(Reading database ... 670661 files and directories currently installed.)
Preparing to unpack .../gitsome_0.8.0+ds-6ubuntu1_all.deb ...
Unpacking gitsome (0.8.0+ds-6ubuntu1) ...
Setting up gitsome (0.8.0+ds-6ubuntu1) ...
/usr/lib/python3/dist-packages/gitsome/github.py:792: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  ('/' + language if language is not 'overall' else '') +
/usr/lib/python3/dist-packages/gitsome/lib/html2text/html2text.py:95: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if c is not ' ' and c is not '  ':
/usr/lib/python3/dist-packages/gitsome/lib/html2text/html2text.py:95: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if c is not ' ' and c is not '  ':
/usr/lib/python3/dist-packages/gitsome/lib/html2text/html2text.py:96: SyntaxWarning: "is" with a literal. Did you mean "=="?
  return c is ' '

Is there any intention of merging this with master branch?

@mkindahl mkindahl mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MBfromOK @mkindahl @donnemartin