No pnew #268
Merged
No pnew #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XFarPtr seems to never take non-const string, therefore we can remove the appropriate ctor and relax the const ctor to not take the reference, but rather the pointer. This way it can accept dir_name from temporaries, which only match to the const pointer.
Closes #266 It appears there is no common denominator available between gcc and clang: gcc doesn't allow unaligned references and clang doesn't allow assignable temporaries. So its simpler to just implement both approaches separated by ifdef's. This eliminates the use of hackrefs.h for gcc, leaving it for clang only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.