-
Notifications
You must be signed in to change notification settings - Fork 233
Add support for node integration testing #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
phil-opp
wants to merge
16
commits into
main
Choose a base branch
from
node-integration-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional `data_format` field that specifies the format of the `data` field. It defaults to deriving the schema from the given JSON object and converting it to the closest Arrow representation. The `ArrowTest` and `ArrowTestUnwrap` formats expect the `data` field to follow the Arrow integration test data format. The `ArrowTestUnwrap` format unwraps the first column of the deserialized RecordBatch to make other Arrow types representable (i.e. not just StructArrays).
The arrow integration test format crate panics in certain situations, which lead to a closed integration test channel. We want to panic on the sending side too in this case to avoid endless loops.
Useful for diffing the file against an expected file (as time offsets are not deterministic).
|
I opened apache/arrow-rs#8737 to add support for binary decoding to |
The `arrow_integration_test` crate is incomplete and apparently only for internal use.
- wrap values if necessary - avoid double-wrapping array values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How it works
DORA_TEST_WITH_INPUTSenv variable with the path to your input JSON fileDORA_TEST_WRITE_OUTPUTS_TOenv variable with the path where the outputs should be written. If not set, dora will write aoutputs.jsonlfile next to the given inputs fileThe node will be run as usual, but its event channel will be filled from the given inputs JSON file. No connection to a
dora daemonwill be made.Input JSON file format example:
Output JSON file format example:
{"id":"random","data":9267023440904143729,"time_offset_secs":0.700793541} {"id":"random","data":5753749540645363621,"time_offset_secs":0.900897584}TODO:
arrow_integration_testJSON format -> this might be better suitable than our custom input json formatuse ArrowTestUnwrap format for outputs.jsonl(not possible because of ArrowJsonBatch::from_batch is incomplete apache/arrow-rs#8684)