Allow async auth providers #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
THanks James, I will take a look at this tomorrow. |
This adds support for async auth providers. There are many use cases for this, for example, authenticating with Kubernetes in AWS but outside of EKS, you need to make API calls to get a frequently rotated token. This allows that token to be looked up in a non blocking way. This also prepares the way for better support for reloading tokens in Kubernetes itself given that they are now frequently rotated.
8788023 to
89de2fb
Compare
jroper
added a commit
to jroper/skuber
that referenced
this pull request
Nov 3, 2025
Fixes doriordan#350 This implements token reloading for in cluster config. It's built on doriordan#424 so that needs to be reviewed/merged first. Also fixed a resource leak where the input streams for reading the files for in cluster config were not being closed. This was necessary to fix given that we're now frequently loading those streams.
Owner
|
LGTM, merged |
jroper
added a commit
to jroper/skuber
that referenced
this pull request
Nov 5, 2025
Fixes doriordan#350 This implements token reloading for in cluster config. It's built on doriordan#424 so that needs to be reviewed/merged first. Also fixed a resource leak where the input streams for reading the files for in cluster config were not being closed. This was necessary to fix given that we're now frequently loading those streams.
doriordan
pushed a commit
that referenced
this pull request
Nov 5, 2025
Fixes #350 This implements token reloading for in cluster config. It's built on #424 so that needs to be reviewed/merged first. Also fixed a resource leak where the input streams for reading the files for in cluster config were not being closed. This was necessary to fix given that we're now frequently loading those streams.
Owner
|
@jroper following this change compilation for 2.12 was broken because |
Contributor
Author
|
Ah good point. |
doriordan
pushed a commit
that referenced
this pull request
Nov 10, 2025
This adds support for async auth providers. There are many use cases for this, for example, authenticating with Kubernetes in AWS but outside of EKS, you need to make API calls to get a frequently rotated token. This allows that token to be looked up in a non blocking way. This also prepares the way for better support for reloading tokens in Kubernetes itself given that they are now frequently rotated.
doriordan
pushed a commit
that referenced
this pull request
Nov 10, 2025
Fixes #350 This implements token reloading for in cluster config. It's built on #424 so that needs to be reviewed/merged first. Also fixed a resource leak where the input streams for reading the files for in cluster config were not being closed. This was necessary to fix given that we're now frequently loading those streams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for async auth providers. There are many use cases for this, for example, authenticating with Kubernetes in AWS but outside of EKS, you need to make API calls to get a frequently rotated token. This allows that token to be looked up in a non blocking way.
This also prepares the way for better support for reloading tokens in Kubernetes itself given that they are now frequently rotated.