Secret type field addition #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 29, 2016 14:17
A Secret has a member: data: Map[String, Array[Byte]] Skuber threw an exception whenever a Secret was serialized or deserialized when this data member was present because the usage of formatMaybeEmptyMap did not allow the injection of: implicit base64Format: Format[Array[Byte]] Thus, the byte array was not being serialized and deserialized via the Base64.decodeBase and Base64.encodeBase64String methods, and whatever it fell back to resulted in a JsValue being created instead of a JsObject. After great, albeit failed, effort to get formatMaybeEmptyMap to correctly use base64Format, I instead created formatMaybeEmptyByteArrayMap which resolved the problem. I suspect that type erasure may preclude a more elegant solution, but would love to know if one is possible. I added unit tests to exercise the problem and solution. Without the corresponding changes to the json package, the first unit test will fail.
To closer align this model to the definition in the Kubernetes v1 documentation: http://kubernetes.io/docs/api-reference/v1/definitions/#_v1_secret
Owner
|
Hi Cory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an addition above this one. Not sure if this is the most idiomatic way to do this in git or not, as this PR contains PR-10 as well.
The commit for this PR is Add "type" field to Secret
I submitted this PR separate from PR-10 because I was uncertain if there was previous reasoning against including the
typemember on Kubernetes objects. It is fairly common, yet seems to be absent in Skuber.For our purposes, we have Kubernetes resources that we need to create that require this property be defined with a specific value.