Make access-token and expiry optional in kubeconfig #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcp auth-provider's access-token and expity fields may be not set in kubeconfig if kubectl has never been used to access the cluster. If this is the case skuber fails with an exception while trying to read kubeconfig because it expects those field to always be present This commit makes access-token and expiry fields optional for the gcp auth-provider Fixes #301
Author
|
Closing in favor of #297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcp auth-provider's access-token and expity fields may be not set in
kubeconfig if kubectl has never been used to access the cluster. If this
is the case skuber fails with an exception while trying to read
kubeconfig because it expects those field to always be present
This commit makes access-token and expiry fields optional for the gcp
auth-provider
Fixes #301