This repository was archived by the owner on May 21, 2024. It is now read-only.
don't directly activate .NET Interactive #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
approved these changes
Feb 2, 2022
Member
JoeRobich
left a comment
There was a problem hiding this comment.
Looks good to me. With the C# extension now generating platform packages that include our dependencies, we no longer need the activation call.
mavasani
approved these changes
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, along with dotnet/interactive#1884 will fix some activation re-entrancy loops. Since the installer automatically adds
dotnet.exeto the path, we don't need to get it from thevscode-dotnet-sdkextension and pass it to .NET Interactive. Instead, .NET Interactive can simply pull it from the path.