Disable loc builds from release branch for 6.0 #5653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Remember to also make this PR into the release branch |
Member
Author
Yes. Once this is clear, Iwill be creating for all of our release branches. we service all the way to 3.1 |
Tanya-Solyanik
previously approved these changes
Aug 31, 2021
…eddy/DisableLocInReleaseBranch
dreddy-work
added a commit
that referenced
this pull request
Sep 1, 2021
dreddy-work
added a commit
that referenced
this pull request
Sep 1, 2021
dreddy-work
added a commit
that referenced
this pull request
Sep 1, 2021
dreddy-work
added a commit
that referenced
this pull request
Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in templates, to disable Loc PRs, is being overridden by Arcade. This is the right place to disable Loc build/ PRs on a branch.
Based my conversation with loc team, Loc tools can target only one branch at a time and branch owners need to notify loc team if there is a change in the branch for which loc need to be run. Ideally, we would always be running loc on
mainbranches and snapping from there. In some specific cases, like templates, we would need to run localization for the changes/fixes we serviced toreleasebranch.For this to work, and because of limitations in loc tools, Only one branch need to be actively triggering loc build at any point in time. Changing branch needs work from loc team and has an SLA of 1-2 weeks. In our case, the best course of action is to wait until
releasebranch is locked for major changes and raise one final request against release branch.PRs we have been seeing in this repo are being triggered against changes in
releaseandmainbranches but or creating PRs against one branch ( that ismain). Hence, sync issues and build failures. To prevent this, I am disabling Loc on all branches except formain. We will raise ticket against loc when we are ready to update loc onreleasebranches.Microsoft Reviewers: Open in CodeFlow