Removed separate MinHeight resources for text based controls #10980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the minimum height values for text-based controls by removing separate control-specific MinHeight resources and standardizing them to use a unified TextControlThemeMinHeight value of 32. The changes eliminate redundant resource definitions and ensure consistent sizing across different text input controls while improving maintainability through centralized resource management.
- Unified MinHeight resource consolidation from separate control-specific values to a single
TextControlThemeMinHeight - Updated the base
TextControlThemeMinHeightvalue from 24 to 32 across all theme files - Improved vertical content alignment for ComboBox controls from "Top" to "Center"
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Fluent.xaml | Updates central theme with unified MinHeight resources and removes deprecated control-specific MinHeight values |
| Fluent.Light.xaml | Applies same consolidation changes for light theme variant |
| Fluent.Dark.xaml | Applies same consolidation changes for dark theme variant |
| Fluent.HC.xaml | Applies same consolidation changes for high contrast theme variant |
| TextBox.xaml | Removes deprecated TextBoxThemeMinHeight resource and updates references |
| RichTextBox.xaml | Removes deprecated RichTextBoxThemeMinHeight resource and updates references |
| PasswordBox.xaml | Removes deprecated PasswordBoxThemeMinHeight resource and updates references |
| DatePicker.xaml | Adds MinHeight property and updates template binding for consistent sizing |
| ComboBox.xaml | Updates MinHeight reference and improves vertical content alignment |
| Variables.xaml | Updates base TextControlThemeMinHeight value from 24 to 32 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10980 +/- ##
===================================================
+ Coverage 13.36769% 13.51885% +0.15116%
===================================================
Files 3319 3319
Lines 664894 664894
Branches 74674 74674
===================================================
+ Hits 88881 89886 +1005
+ Misses 573472 572462 -1010
- Partials 2541 2546 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
harshit7962
approved these changes
Jul 17, 2025
Member
harshit7962
left a comment
There was a problem hiding this comment.
Apart from the sole query, the changes looks fine.
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/RichTextBox.xaml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts a workaround that I had to introduce while fixing the layout of text controls ( DatePicker, TextBox, RichTextBox, PasswordBox, etc ). These all controls use a shared resource TextControlThemeMinHeight, which needed to be changed from 24 to 32. However, in each PR I only fixed a single style, I had to introduce individual resources for these controls at the time.
In this PR, I remove the extra resources and their references are replaced with TextControlThemeMinHeight resource.
Customer Impact
Anyone modifying this resource will see the uniform behavior for all text based controls.
Regression
N/A
Testing
Local app testing
Risk
Minimal. Minor issues in content alignment may come up.
Microsoft Reviewers: Open in CodeFlow