Added license headers in fluent style files #10989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds MIT license headers to Fluent style XAML files that were missing them, addressing issue #8554. The changes ensure consistent licensing headers across all XAML files in the Fluent theme implementation.
Key Changes:
- Added license headers to 16 XAML files in the Fluent theme styles and themes directories
- Updated the theme generator script to include license headers in generated files
- Distinguished between generated files (with generation warnings) and source files (standard license headers)
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Fluent.xaml, Fluent.Light.xaml, Fluent.Dark.xaml, Fluent.HC.xaml | Added license headers with generation warnings to theme files |
| Various Styles/*.xaml files | Added standard license headers to individual style files |
| ThemeGenerator.Fluent.ps1 | Updated generator to include license headers in generated output |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10989 +/- ##
===================================================
- Coverage 13.52892% 13.42740% -0.10152%
===================================================
Files 3319 3319
Lines 664894 664894
Branches 74674 74674
===================================================
- Hits 89953 89278 -675
- Misses 572397 573072 +675
Partials 2544 2544
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
harshit7962
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #8554
Description
Some files added in fluent styles were missing licensing headers. This PR just adds those licensing header for XAML files. For C# files the rule is enforced by editorconfig.
Customer Impact
--
Regression
No
Testing
None
Risk
None
Microsoft Reviewers: Open in CodeFlow