Add System.Private.Windows.Core.TestUtilities to Version.Details.xml #11049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the VMR can properly override the version used.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the System.Private.Windows.Core.TestUtilities dependency from a hardcoded version in Versions.props to the centralized dependency management system, allowing the VMR (Virtual Monorepo) to properly override the version used.
Key changes:
- Removes hardcoded version definition from Versions.props
- Adds dependency entry to Version.Details.xml with proper metadata
- Adds corresponding version properties to Version.Details.props
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Versions.props | Removes hardcoded SystemPrivateWindowsCoreTestUtilitiesVersion property |
| eng/Version.Details.xml | Adds System.Private.Windows.Core.TestUtilities dependency with version and source metadata |
| eng/Version.Details.props | Adds package version property and maps it to the version variable |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
ViktorHofer
approved these changes
Aug 13, 2025
Member
Author
|
cc @harshit7962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the VMR can properly override the version used.
Microsoft Reviewers: Open in CodeFlow