Remove modification of MSBuildAllProjects property #2181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 16.0 MSBuild automatically prepends the most recently modified import to this property, so there's no need to ensure all imports do this themselves. In fact, doing so actively harms performance as this property's value becomes very large and processing it is expensive. I assume this SDK does not need to support VS versions earlier than 16.0.
rainersigwald
approved these changes
Nov 12, 2019
nguerrera
approved these changes
Nov 12, 2019
vatsan-madhavan
approved these changes
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 16.0, MSBuild automatically prepends the most recently modified import to this property, so there's no need to ensure all imports do this themselves. In fact, doing so actively harms performance as this property's value becomes very large and processing it is expensive.
I assume this SDK does not need to support VS versions earlier than 16.0.