Remove Prometheus commented out code that does not work #4096
Conversation
|
We need an fwlink pointing at a doc for adding this |
|
Is that something that @samsp-msft was working on? My suggestion here is to get this in to try to start getting the build ready and the insertion PR, and then if we can get the fwlink to point to where we want to we merge that in and update the insertion, thoughts? Or the other alternative, I can add a fwlink here that points to nothing right now, and we fix that later. |
|
RE fwlink, can we use an aka.ms link instead? They're much nicer to look at. |
...re.ProjectTemplates/templates/aspire-empty/AspireApplication.1.ServiceDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
…cation.1.ServiceDefaults/Extensions.cs
|
Added a comment to the top with an aka.ms link. That currently points to the service-defaults topic. We can now grow that help content and move the link destination if applicable. |
|
Are folks happy with this, is this ready to go? @DamianEdwards @davidfowl |
|
|
||
| namespace Microsoft.Extensions.Hosting; | ||
|
|
||
| // Adds common .NET Aspire services: service discovery, resilience, health checks and OpenTelemetry |
There was a problem hiding this comment.
Ideally we'd add xml docs to the methods in these but this is fine for now
|
I thought we were adding an aka.ms link about how to add prometheus... |
...re.ProjectTemplates/templates/aspire-empty/AspireApplication.1.ServiceDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
src/Aspire.ProjectTemplates/templates/aspire-servicedefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
...tTemplates/templates/aspire-starter/AspireStarterApplication.1.ServiceDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
src/Aspire.ProjectTemplates/templates/aspire-servicedefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
...re.ProjectTemplates/templates/aspire-empty/AspireApplication.1.ServiceDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
...tTemplates/templates/aspire-starter/AspireStarterApplication.1.ServiceDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: James Newton-King <[email protected]>
...re.ProjectTemplates/templates/aspire-empty/AspireApplication.1.ServiceDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
src/Aspire.ProjectTemplates/templates/aspire-servicedefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
...tTemplates/templates/aspire-starter/AspireStarterApplication.1.ServiceDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
|
Merging to prepare the insertion. All changes are in commented out lines. |
As discussed this morning and logged in #4092, removing Prometheus commented out code from the templates given it doesn't currently worked becase of open-telemetry/opentelemetry-dotnet-contrib#1617
There are still some of these lines in the playground and test aspire projects in the repo, but limiting the changes here to only the templates.
cc: @DamianEdwards, @samsp-msft
Microsoft Reviewers: Open in CodeFlow