[release/8.2] Update MongoDB to 2.28 #5477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a breaking change between 2.27 and 2.28 - MongoDB.Driver added an assembly strong name. We can now remove our NoWarn workarounds for MongoDB. Except Aspire.MongoDB.Driver still needs the NoWarn for 2 the health check and DiagnosticSource packages.
Member
|
Fixing an already broken scenario (people using Mongo higher than 2.27), customer reported, low (isolated) risk. Approved. |
eerhardt
approved these changes
Aug 28, 2024
sebastienros
approved these changes
Aug 28, 2024
Member
|
Failure is unrelated and seems to be an issue with our elasticsearch image in the container registry. I'm merging this in favor of getting an 8.2 build out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5476 to release/8.2
/cc @eerhardt
Customer Impact
Customers are unable to use the new MongoDB.Driver version because it is now strong name signed. For example, if the user is using the 8.1 version of MongoDB.EntityFrameworkCore and Aspire.MongoDB.Driver, their build is broken today. This allows our customers to upgrade to the latest MongoDB.Driver dependency.
Testing
Automated tests in the repo.
Risk
Only affects MongoDB. If something else in the users application uses a the 2.27 version of MongoDB.Driver, updating to the new version of Aspire.MongoDB.Driver will break them.
Regression?
No. But scenarios no longer work if the users updates
MongoDB.EntityFrameworkCorefrom8.0.0to8.0.1.