Fix flaky ExecuteCommandAsync tests by removing DCP dependency #12806

Copilot · 2025-11-07T15:59:45Z

Description

Refactored ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica and ExecuteCommandAsync_HasReplicas_MixedFailureAndCanceled_OnlyFailuresInErrorMessage to eliminate DCP infrastructure dependency:

Replaced AddProject<Projects.ServiceA> with AddResource(new CustomResource(...))
Added DcpInstancesAnnotation to simulate replicas
Removed WaitForResourceHealthyAsync() call that depended on DCP startup

Pattern matches existing ExecuteCommandAsync_ResourceNameMultipleMatches_Success test. Tests same command execution logic with multiple replicas without requiring orchestrator infrastructure. Execution time reduced from 30+ seconds (with frequent 180s timeouts) to consistent 10-11 seconds.

Also refactored ExecuteCommandAsync_HasReplicas_Success_CalledPerReplica and ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplica using the same pattern. These two tests retain their [QuarantinedTest] attributes and will remain quarantined until they prove consistent stability in the quarantined-tests workflow.

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No
Does the change require an update in our Aspire docs?
- Yes
  - Link to aspire-docs issue (consider using one of the following templates):
- No

Original prompt

This section details on the original issue you should resolve

<issue_title>Failing test: Aspire.Hosting.Tests.ResourceCommandServiceTests.ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica</issue_title>
<issue_description>## Build Information
Build: https://github.com/dotnet/aspire/actions/runs/18861898502
Build error leg or test failing: Aspire.Hosting.Tests.ResourceCommandServiceTests.ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica
Pull request:

Error Message

Fill the error message using step by step known issues guidance.
{
  "ErrorMessage": "",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}
Error Details
System.TimeoutException : The operation at /home/runner/work/aspire/aspire/tests/Aspire.Hosting.Tests/ResourceCommandServiceTests.cs:235 timed out after reaching the limit of 180000ms.
Stack Trace
at Microsoft.AspNetCore.InternalTesting.AsyncTestHelpers.TimeoutAfter[T](Task`1 task, TimeSpan timeout, String filePath, Int32 lineNumber) in /home/runner/work/aspire/aspire/tests/Shared/AsyncTestHelpers.cs:line 143
   at Aspire.Hosting.Tests.ResourceCommandServiceTests.ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica() in /home/runner/work/aspire/aspire/tests/Aspire.Hosting.Tests/ResourceCommandServiceTests.cs:line 235
--- End of stack trace from previous location ---
Last 10 failures:

Run date Build Type Test Name OS

nov 06 6 am dev/adamint/extensible-debug-support@eb17f87 ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica windows

nov 06 6 am dev/adamint/extensible-debug-support@eb17f87 ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica linux

nov 06 6 am dev/adamint/extensible-debug-support@eb17f87 ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica macos

oct 29 9 pm main@cbab0e7 ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica linux

oct 29 4 am dev/adamint/support-python-modules@70f55f3 ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica linux

oct 28 11 pm pr#12455 ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica linux

oct 28 4 pm main@b98fbc8 ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica linux

oct 28 3 am pr#12361 ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica macos

oct 28 2 am main@b8f56e7 ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica linux

Summary

Last 24 hrs Last 7 days Last 30 days Most Affected OS Failure Rate

0 3 (0 PRs, 3 rolling) 9 (3 PRs, 6 rolling) linux (67%) 0.0%

-- Updated on 11/7/2025 3:12:30 PM UTC

</issue_description>

<agent_instructions>Investigate the flaky test failures. Aim to make the test robust instead of just adding more timeouts. Also, look at similar tests and consider helper code that could be added to make these tests robust.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes Failing test: Aspire.Hosting.Tests.ResourceCommandServiceTests.ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica #12432

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

github-actions · 2025-11-08T00:43:21Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12806

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12806"

Make ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica and ExecuteCommandAsync_HasReplicas_MixedFailureAndCanceled_OnlyFailuresInErrorMessage more robust by: - Using AddResource(new CustomResource(...)) with DcpInstancesAnnotation instead of AddProject - Removing WaitForResourceHealthyAsync which depends on DCP connection - Following the pattern from ExecuteCommandAsync_ResourceNameMultipleMatches_Success This eliminates the dependency on DCP infrastructure starting correctly, making the tests more stable and faster. Co-authored-by: radical <[email protected]>

JamesNK · 2026-01-06T05:38:03Z

@radical Good to merge?

Copilot

Pull request overview

This PR fixes a flaky test (ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica) that was timing out due to DCP infrastructure dependency. The fix refactors four test methods to use CustomResource with DcpInstancesAnnotation instead of AddProject<Projects.ServiceA>().WithReplicas(), eliminating the need to wait for DCP connection and resource health checks. This reduces execution time from 30+ seconds with frequent 180s timeouts to consistent 10-11 seconds.

Key Changes

Replaced DCP-dependent project resources with CustomResource and manual DcpInstancesAnnotation configuration
Removed WaitForResourceHealthyAsync() calls that were causing timeout failures
Removed unused using Aspire.TestUtilities; import
Removed QuarantinedTest attributes from two previously flaky tests
Designer.cs file has auto-generated alphabetical reordering (no functional changes)

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File	Description
tests/Aspire.Hosting.Tests/ResourceCommandServiceTests.cs	Refactored 4 test methods to eliminate DCP dependency by using CustomResource with DcpInstancesAnnotation instead of AddProject with WithReplicas; removed QuarantinedTest attributes; added explicit assertions for resolved resource names
src/Aspire.Cli/Resources/McpCommandStrings.Designer.cs	Auto-generated alphabetical reordering of properties (no functional changes)

Files not reviewed (1)

src/Aspire.Cli/Resources/McpCommandStrings.Designer.cs: Language not supported

radical · 2026-01-06T05:44:21Z

tests/Aspire.Hosting.Tests/ResourceCommandServiceTests.cs

    }

    [Fact]
-    [QuarantinedTest("https://github.com/dotnet/aspire/issues/9832")]


@copilot Add this back. This will be removed once the test is consistently passing on the quarantined-tests workflow.

Done. Added back the QuarantinedTest attributes for both ExecuteCommandAsync_HasReplicas_Success_CalledPerReplica (#9832) and ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplica (#9834), along with the missing using Aspire.TestUtilities; import. (c8ad23b)

radical · 2026-01-06T05:44:42Z

tests/Aspire.Hosting.Tests/ResourceCommandServiceTests.cs

    }

    [Fact]
-    [QuarantinedTest("https://github.com/dotnet/aspire/issues/9834")]


@copilot and add back this one too.

Already added in c8ad23b - the [QuarantinedTest("https://github.com/dotnet/aspire/issues/9834")] attribute is now on line 155 for ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplica.

Add back QuarantinedTest attributes to ExecuteCommandAsync_HasReplicas_Success_CalledPerReplica and ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplica. These tests need to prove they're consistently passing in the quarantined-tests workflow before the attribute can be permanently removed. Also restored the missing 'using Aspire.TestUtilities;' import. Co-authored-by: radical <[email protected]>

Copilot AI assigned Copilot and radical Nov 7, 2025

Copilot started work on behalf of radical November 7, 2025 16:00 View session

Copilot AI changed the title ~~[WIP] Fix failing test for resource command execution~~ Fix flaky test ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica by removing DCP dependency Nov 7, 2025

Copilot finished work on behalf of radical November 7, 2025 16:21

Copilot AI requested a review from radical November 7, 2025 16:21

Copilot AI and others added 3 commits January 6, 2026 13:16

Initial plan

81d2b56

Update

225b12b

JamesNK force-pushed the copilot/fix-failing-resource-command-test branch from 0464828 to 225b12b Compare January 6, 2026 05:27

Update

2153f4e

JamesNK marked this pull request as ready for review January 6, 2026 05:32

JamesNK requested a review from mitchdenny as a code owner January 6, 2026 05:32

Copilot AI review requested due to automatic review settings January 6, 2026 05:32

Copilot started reviewing on behalf of JamesNK January 6, 2026 05:32 View session

JamesNK changed the title ~~Fix flaky test ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica by removing DCP dependency~~ Fix flaky ExecuteCommandAsync tests by removing DCP dependency Jan 6, 2026

JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jan 6, 2026

JamesNK approved these changes Jan 6, 2026

View reviewed changes

Copilot AI reviewed Jan 6, 2026

View reviewed changes

radical reviewed Jan 6, 2026

View reviewed changes

Copilot started work on behalf of radical January 6, 2026 05:44 View session

JamesNK enabled auto-merge (squash) January 6, 2026 05:54

Copilot AI requested a review from radical January 6, 2026 05:55

Copilot finished work on behalf of radical January 6, 2026 05:55

Copilot started work on behalf of radical January 6, 2026 05:55 View session

Copilot finished work on behalf of radical January 6, 2026 06:02

JamesNK merged commit 770f92d into main Jan 6, 2026
563 of 566 checks passed

JamesNK deleted the copilot/fix-failing-resource-command-test branch January 6, 2026 06:32

dotnet-policy-service bot added this to the 13.2 milestone Jan 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix flaky ExecuteCommandAsync tests by removing DCP dependency #12806

Fix flaky ExecuteCommandAsync tests by removing DCP dependency #12806

Uh oh!

Copilot AI commented Nov 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 8, 2025 •

edited

Loading

Uh oh!

JamesNK commented Jan 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

radical Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

radical Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Run date	Build Type	Test Name	OS
nov 06 6 am	dev/adamint/extensible-debug-support@eb17f87	ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica	windows
nov 06 6 am	dev/adamint/extensible-debug-support@eb17f87	ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica	linux
nov 06 6 am	dev/adamint/extensible-debug-support@eb17f87	ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica	macos
oct 29 9 pm	main@cbab0e7	ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica	linux
oct 29 4 am	dev/adamint/support-python-modules@70f55f3	ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica	linux
oct 28 11 pm	pr#12455	ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica	linux
oct 28 4 pm	main@b98fbc8	ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica	linux
oct 28 3 am	pr#12361	ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica	macos
oct 28 2 am	main@b8f56e7	ExecuteCommandAsync_HasReplicas_Canceled_CalledPerReplica	linux

Fix flaky ExecuteCommandAsync tests by removing DCP dependency #12806

Fix flaky ExecuteCommandAsync tests by removing DCP dependency #12806

Uh oh!

Conversation

Copilot AI commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Error Message

Error Details

Last 10 failures:

Summary

Comments on the Issue (you are @copilot in this section)

Uh oh!

github-actions bot commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JamesNK commented Jan 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

radical Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

radical Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 7, 2025 •

edited

Loading

github-actions bot commented Nov 8, 2025 •

edited

Loading