Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add DeployCompute meta step to deployment pipeline #13567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add DeployCompute meta step to deployment pipeline #13567

Copilot wants to merge 4 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Dec 15, 2025 •
edited
Loading

Description

Introduces WellKnownPipelineSteps.DeployCompute as a meta step coordinating all compute deployment operations (projects, containers, dockerfiles). The step aggregates individual resource deploy steps before the final Deploy step executes.

Pipeline structure:

resource deploy steps → deploy-compute → deploy

Changes:

  • Added DeployCompute constant to WellKnownPipelineSteps
  • Initialize deploy-compute meta step in pipeline, required by Deploy
  • Updated AzureContainerAppResource and AzureAppServiceWebSiteResource deploy steps to be required by DeployCompute
  • Updated diagnostics snapshot test reflecting new dependency graph

Fixes #13618

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • aka.ms
    • Triggering command: /usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-bicepbS2Txr/aas-env-acr.module.bicep --stdout (dns block)
    • Triggering command: /usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-biceptUz4av/storage.module.bicep --stdout (dns block)
    • Triggering command: /usr/local/bin/bicep /usr/local/bin/bicep build /tmp/aspire-bicepm4oQTv/aca-env-acr.module.bicep --stdout (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Add a "deploy all compute" meta step to aspire deploy</issue_title>
<issue_description>Introduce a meta step to deploy all compute resources in the aspire deploy workflow for v13. This step should streamline the deployment of all compute-related components.</issue_description>

<agent_instructions>Add a WellKnownPipelineStep for DeployCompute. Make this pipeline step required by all the provision steps on compute resources like ProjectResource and the provision steps on container-based resources. Add test coverage that uses snapshot testing on the diagnostics command to verify that the parenting works correctly for AddProject, AddDockerfile, and AddContainer resources.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Add deploy all compute meta step to aspire deploy Add DeployCompute meta step to deployment pipeline Dec 15, 2025
Copilot AI requested a review from captainsafia December 15, 2025 19:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025 •
edited
Loading

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13567

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13567"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13567

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13567"

@captainsafia captainsafia marked this pull request as ready for review December 16, 2025 00:40
Copilot AI review requested due to automatic review settings December 16, 2025 00:40
Copilot AI reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new DeployCompute meta step to the deployment pipeline that coordinates all compute deployment operations (projects, containers, dockerfiles). The step aggregates individual resource deploy steps before the final Deploy step executes, creating a clearer pipeline structure: resource deploy steps → deploy-compute → deploy.

Key changes:

  • Added WellKnownPipelineSteps.DeployCompute constant with appropriate XML documentation
  • Initialized the deploy-compute meta step in DistributedApplicationPipeline as a prerequisite for the Deploy step
  • Updated AzureContainerAppResource and AzureAppServiceWebSiteResource deploy steps to be required by DeployCompute

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Aspire.Hosting/Pipelines/WellKnownPipelineSteps.cs Added new DeployCompute constant with XML documentation
src/Aspire.Hosting/Pipelines/DistributedApplicationPipeline.cs Initialized deploy-compute meta step as prerequisite for Deploy step
src/Aspire.Hosting.Azure.AppService/AzureAppServiceWebSiteResource.cs Updated deploy step to be required by DeployCompute
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppResource.cs Updated deploy step to be required by DeployCompute
tests/Aspire.Hosting.Tests/Pipelines/DistributedApplicationPipelineTests.cs Updated test to account for new step (whitespace cleanup)
tests/Aspire.Hosting.Azure.Tests/Snapshots/*.verified.txt Updated snapshot tests reflecting new dependency graph structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@captainsafia captainsafia

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a "deploy all compute" meta step to aspire deploy

2 participants

@captainsafia