Add Docker/Podman version check to aspire doctor command #13650
+379
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add minimum version constants (Docker 20.10.0, Podman 4.0.0) - Parse version from container runtime --version output - Warn if detected version is below minimum required - Display version in pass message for successful checks - Add comprehensive unit tests for version parsing Co-authored-by: davidfowl <[email protected]>
- Change from --version to 'version -f json' for more reliable parsing - Add ParseVersionFromJsonOutput method to parse Client.Version from JSON - Keep ParseVersionFromOutput as fallback for non-JSON output - Add comprehensive tests for JSON version parsing Co-authored-by: davidfowl <[email protected]>
Copilot
AI
changed the title
[WIP] Add docker and podman version check to aspire doctor
Add Docker/Podman version check to aspire doctor command
Dec 18, 2025
Member
|
@copilot If we set a min supported Docker version of 28.0.0, that feels pretty reasonable |
Per feedback from @davidfowl, updated the minimum supported versions: - Docker: 28.0.0 (was 20.10.0) - Podman: 5.0.0 (was 4.0.0) Co-authored-by: davidfowl <[email protected]>
Contributor
Author
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13650Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13650" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds version checking for Docker and Podman in the
aspire doctorcommand. Detects outdated container runtimes and warns users to upgrade.Changes:
version -f jsonfor reliable version parsing from both runtimesExample output with outdated Docker:
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplateOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.