This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Don't add the ReleaseSuffix to the branding on the CLI #9329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhuene
approved these changes
May 22, 2018
peterhuene
reviewed
May 22, 2018
build/Version.props
Outdated
| <CliVersionPrefix>$(CliVersionNoSuffix)-$(ReleaseSuffix)</CliVersionPrefix> | ||
| <CliBrandingVersion>$(CliVersionNoSuffix) - $(ReleaseSuffix)</CliBrandingVersion> | ||
| <CliBrandingVersion Condition=" '$(DropSuffix)' != 'true' ">$(CliVersionNoSuffix) - $(ReleaseSuffix)</CliBrandingVersion> | ||
| <CliBrandingVersion Condition=" '$(CliBrandingVersion)'== '' ">$(CliVersionNoSuffix)</CliBrandingVersion> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
a395df2 to
1e42d13
Compare
nguerrera
reviewed
May 22, 2018
build/Version.props
Outdated
| <CliVersionPrefix>$(CliVersionNoSuffix)-$(ReleaseSuffix)</CliVersionPrefix> | ||
| <CliBrandingVersion>$(CliVersionNoSuffix) - $(ReleaseSuffix)</CliBrandingVersion> | ||
| <CliBrandingVersion Condition=" '$(DropSuffix)' != 'true' ">$(CliVersionNoSuffix) - $(ReleaseSuffix)</CliBrandingVersion> | ||
| <CliBrandingVersion Condition=" '$(CliBrandingVersion)' == '' ">$(CliVersionNoSuffix)</CliBrandingVersion> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
nguerrera
approved these changes
May 22, 2018
…x is set to true.
1e42d13 to
6dfa6af
Compare
nguerrera
approved these changes
May 22, 2018
Author
|
@dotnet-bot Test fedora.27 x64 Debug Build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't add the ReleaseSuffix to the branding on the CLI when DropSuffix is set to true.
Fixes https://github.com/dotnet/cli/issues/9328