Chain the sharedfx and sharedhost MSIs into a single dotnet redist bundle. #1941
Conversation
|
I really wish we would segment the packing folder by component and then os, not OS and component. i.e. keep |
| <?xml version="1.0" encoding="utf-8"?> | ||
| <WixLocalization Culture="en-us" Language="1033" xmlns="http://schemas.microsoft.com/wix/2006/localization"> | ||
| <String Id="Caption">[WixBundleName] Setup</String> | ||
| <String Id="Title">Microsoft Dotnet CLI for Windows</String> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
My idea was to keep similar scripts together. That makes for better segregation. Also OSX scripts were previously clubbed together. |
|
We took on a new pivot in the packaging scripts that added to pre-existing source code organization issues. Let's get things building, then reconsider how the source is organized. |
5f4b8dc to
aeaced5
Compare
|
rebased this atop rel/1.0.0 to get rid of known build breaks. @Sridhar-MS FYI |
|
Thanks @piotrpMSFT |
Change 'Dotnet' to '.Net' in the bundles.
| <String Id="Title">Microsoft .Net CLI for Windows</String> | ||
| <String Id="Motto">You just need a shell, a text editor and 10 minutes of your time. | ||
|
|
||
| Ready? Set? Let's go!</String> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
OSX Jenkins slave went offline during the build - http://dotnet-ci.cloudapp.net/job/dotnet_cli/job/rel_1.0.0/job/release_osx_x64_prtest/337/console cc: @mmitche |
|
@dotnet-bot test OSX x64 Release Build |
|
@Sridhar-MS can we merge? |
|
Yes. |
Chain the sharedfx and sharedhost MSIs into a single dotnet redist bundle.
cc @ellismg @Petermarcu
This change is