Fix VMR source-only build to use --with-packages for prebuilts #3824
Conversation
…with-sdk and --with-packages
…archive directory entirely
… prep and build scripts
|
There's a script error: |
|
@csa7mdm - I see activity from you of merging but not addressing the build issue. Are you planning on doing that? |
There was a problem hiding this comment.
Pull request overview
This pull request modifies the VMR source-only build pipeline to properly test the --with-packages argument by changing where prebuilt artifacts are downloaded and extracted. Previously, artifacts were downloaded to the default location (prereqs/packages/archive/), allowing build.sh to find them implicitly without exercising the --with-packages code path.
Key Changes:
- Changed
reuseBuildArtifactsFromparameter type from string to array (object) - Modified artifact download destination from default location to a custom temporary directory
- Added explicit
--with-packagesargument construction when reusing build artifacts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
- Remove extra 'fi' causing syntax error on line 632 - Remove empty conditional block that served no purpose - Guard for-loop over customEnvVars against empty variable to prevent potential syntax errors in some bash versions
Co-authored-by: Copilot <[email protected]>
Fixes dotnet/source-build#4427
Technical Analysis
The VMR validation pipeline (
vmr-build.yml) was downloading prebuilt artifacts to the defaultprereqs/packages/archive/location, which allowedbuild.shto pick them up implicitly. This left the explicit--with-packagesargument path untested in CI.Changes
eng/pipelines/templates/jobs/vmr-build.ymlto download prebuilts to a custom location (prebuilt-packages/).--with-packagestobuild.shwhenreuseBuildArtifactsFromis set.CustomPreviouslySourceBuiltPackagesPathlogic in the build script is exercised and verified.Verification
build.shaccepts the--with-packagesargument.