Support maui/android/ios workload manifests for source build #3897
+4,815
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables MAUI, Android, and iOS workload support for source-build by adding text-only manifest packages to the source-build-reference-packages (SBRP) repository. The changes bypass the need to add the full maui, android, and macios repositories to the Virtual Monolithic Repository (VMR), which would be costly due to their non-standard build processes and dependencies.
Key changes:
- Added text-only packages for 6 workload manifests (Android, iOS, MacCatalyst, macOS, MAUI, tvOS) with version preview.6
- Removed
Condition="'$(DotNetBuildSourceOnly)' != 'true'"from BundledManifests.targets to enable these workloads in source-only builds - Added documentation comment in Versions.props noting that version updates require corresponding SBRP package updates
Reviewed changes
Copilot reviewed 40 out of 47 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| BundledManifests.targets | Removed source-only build exclusion condition for all 6 workload manifests |
| Versions.props | Added comment documenting SBRP update requirements for workload manifest versions |
| microsoft.net.sdk.android.manifest-* | Added Android workload text-only package with manifest files, license, and metadata |
| microsoft.net.sdk.ios.manifest-* | Added iOS workload text-only package with manifest files, license, and metadata |
| microsoft.net.sdk.maccatalyst.manifest-* | Added MacCatalyst workload text-only package with manifest files, license, and metadata |
| microsoft.net.sdk.macos.manifest-* | Added macOS workload text-only package with manifest files, license, and metadata |
| microsoft.net.sdk.maui.manifest-* | Added MAUI workload text-only package with manifest files, license, and metadata |
| microsoft.net.sdk.tvos.manifest-* | Added tvOS workload text-only package with manifest files, license, and metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...oft.net.sdk.macos.manifest-10.0.100-preview.6/15.5.10415-net10-p6/data/WorkloadManifest.json
Outdated
Show resolved
Hide resolved
...osoft.net.sdk.ios.manifest-10.0.100-preview.6/18.5.10415-net10-p6/data/WorkloadManifest.json
Outdated
Show resolved
Hide resolved
...soft.net.sdk.tvos.manifest-10.0.100-preview.6/18.5.10415-net10-p6/data/WorkloadManifest.json
Outdated
Show resolved
Hide resolved
...t.sdk.maccatalyst.manifest-10.0.100-preview.6/18.5.10415-net10-p6/data/WorkloadManifest.json
Outdated
Show resolved
Hide resolved
MichaelSimons
approved these changes
Dec 16, 2025
Member
MichaelSimons
left a comment
There was a problem hiding this comment.
Before closing the related issue, I would like to discuss the possibility of backporting this given the simplicity of the approach.
Member
Author
|
@jonathanpeppers - Since you've been updating the maui versions, these changes are relevant to you. The recommendation is to now apply these changes in Let me know if more clarity is needed in comments as far as what needs to be done. |
....sdk.android.manifest-10.0.100-preview.6/36.0.0-preview.6.169/data/WorkloadDependencies.json
Outdated
Show resolved
Hide resolved
Updates SBRP to reflect new manifest versions
MichaelSimons
approved these changes
Dec 18, 2025
jonathanpeppers
approved these changes
Dec 18, 2025
MichaelSimons
pushed a commit
to MichaelSimons/dotnet
that referenced
this pull request
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3242
This supports these workload manifests by adding them as text-only packages to SBRP. Then it was just a matter of enabling them in a source-only configuration by removing the condition that excluded them.
While there is cost associated with maintaining these packages in SBRP, that is limited to just the preview part of the release cycle. After GA, the versions will be static.
The alternative to using SBRP is adding the maui, android, and macios repos to the VMR and building the workload manifest packages as part of the build. But this is particularly costly, particularly for the android and macios repos, as they don't follow standard arcade build processes. Instead they have custom logic in Makefiles which dynamically generate the content files that get included in the packages. This dynamic behavior has a number of dependency that are not source-build compatible and would require a fair amount of effort and coordination.