Add extra parameter to get nearest #3912
Draft
+34
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@nkolev92 assuming that this one is for demo / validation purposes, I will convert the PR to draft to make sure that no one merges this yet. We have rotations here, etc. So just to be sure :) |
ViktorHofer
reviewed
Dec 16, 2025
| <GetReferenceNearestTargetFrameworkTask AnnotatedProjectReferences="@(_ProjectReferenceTargetFrameworkPossibilities)" | ||
| CurrentProjectTargetFramework="$(ReferringTargetFrameworkForProjectReferences)" | ||
| CurrentProjectTargetPlatform="$(TargetPlatformMoniker)" | ||
| CurrentProjectTargetFrameworkProperty="$(TargetFramework)" |
Member
There was a problem hiding this comment.
Would you mind describing the difference between this parameter and the CurrentProjectTargetFramework one?
Contributor
Author
There was a problem hiding this comment.
CurrentProjectTargetFramework is the TargetFrameworkMoniker
CurrentProjectTargetFrameworkProperty is the TargetFramework property itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMR version of dotnet/msbuild#12932.