Add extra parameter to get nearest #3913
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new CurrentProjectTargetFrameworkProperty parameter to the GetReferenceNearestTargetFrameworkTask, maintaining backward compatibility with older NuGet versions. The change introduces a conditional invocation strategy where the task is called with the new parameter when supported, or falls back to the previous behavior when not supported.
- Adds
CurrentProjectTargetFrameworkPropertyparameter to pass$(TargetFramework)value - Introduces gating logic based on
GetReferenceNearestTargetFrameworkTaskSupportsTargetFrameworkPropertyParameterproperty - Duplicates the task invocation to handle both new and legacy NuGet versions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Output ItemName="AnnotatedProjects" TaskParameter="AssignedProjects" /> | ||
| </GetReferenceNearestTargetFrameworkTask> | ||
|
|
||
| <!-- Pass the CurrentProjectTargetPlatform parameter to the task only if GetReferenceNearestTargetFrameworkTaskSupportsTargetPlatformParameter is true and GetReferenceNearestTargetFrameworkTaskSupportsTargetFrameworkPropertyParameter is not true. This means |
There was a problem hiding this comment.
The comment incorrectly states 'Pass the CurrentProjectTargetPlatform parameter' when it should describe the purpose of this second task invocation as a fallback for older NuGet versions that don't support the new CurrentProjectTargetFrameworkProperty parameter. The comment should clarify this is for backward compatibility.
| <GetReferenceNearestTargetFrameworkTask AnnotatedProjectReferences="@(_ProjectReferenceTargetFrameworkPossibilities)" | ||
| CurrentProjectTargetFramework="$(ReferringTargetFrameworkForProjectReferences)" | ||
| CurrentProjectTargetPlatform="$(TargetPlatformMoniker)" | ||
| CurrentProjectTargetFrameworkProperty="$(TargetFramework)" |
There was a problem hiding this comment.
The new parameter is only added to the first task invocation (lines 1889-1898) but not to the fallback invocation (lines 1903-1911). While this appears intentional for backward compatibility, there's duplicate task logic that could be error-prone during future maintenance. Consider adding a comment explaining why this parameter is omitted in the second invocation.
VMR version of dotnet/msbuild#12932