Revert .dotnet dir removal for MicroBuild isolation #3952
Conversation
|
Blocked on #3892. This is not blocked in 10.0 branches. |
…llation Co-authored-by: mthalman <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR aims to revert the removal of the .dotnet directory that was introduced in PR #2895, based on the claim that Arcade PR #16091 has isolated MicroBuild's .NET SDK installation to a separate .dotnet-microbuild directory.
Key Changes
- Removed
rm -rf $(sourcesPath)/.dotnetcommand before SDK extraction - Changed
mkdir $(sourcesPath)/.dotnettomkdir -p $(sourcesPath)/.dotnetfor idempotent directory creation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
| if [[ "$prepSdk" == "false" ]]; then | ||
| customPrepArgs="${customPrepArgs} --no-sdk" |
There was a problem hiding this comment.
The removal of the rm -rf $(sourcesPath)/.dotnet command may be premature. While the PR description states that MicroBuild now uses an isolated .dotnet-microbuild directory (from Arcade PR #16091), the root-level eng/common/core-templates/steps/install-microbuild.yml file (line 29) still installs the MicroBuild .NET SDK to .dotnet, not .dotnet-microbuild. This means both the MicroBuild installation (line 454) and this SDK extraction could potentially write to the same $(sourcesPath)/.dotnet directory, causing conflicts. The rm -rf command should be retained until the root-level MicroBuild installation template is updated to use .dotnet-microbuild.
| customPrepArgs="${customPrepArgs} --no-sdk" | |
| customPrepArgs="${customPrepArgs} --no-sdk" | |
| rm -rf $(sourcesPath)/.dotnet |
|
/backport to release/10.0.1xx |
|
Started backporting to |
|
/backport to release/10.0.2xx |
|
Started backporting to |
Reverts PR #2895 changes now that Arcade PR #16091 has flowed in, which isolates MicroBuild's .NET SDK to
.dotnet-microbuild.Changes
rm -rf $(sourcesPath)/.dotnetfrom vmr-build.yml prep stepmkdir -pfor idempotent directory creationPreviously, the
.dotnetdirectory was removed to avoid conflicts with MicroBuild's SDK installation. MicroBuild now uses its own isolated.dotnet-microbuildpath (configured ininstall-microbuild.yml), eliminating the need for removal.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.