Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway requested review from a team as code owners December 19, 2025 02:51
Copilot AI review requested due to automatic review settings December 19, 2025 02:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-bootstraps the repository to .NET version 11.0.100-alpha.1.25618.104, updating build infrastructure and tooling from version 10.0.x to 11.0.x. This is a major version update that includes updates to the .NET SDK, Arcade SDK, and supporting build infrastructure scripts.

Key changes include:

  • Upgrade from .NET SDK 10.0.100 to 11.0.100-alpha.1.25618.104
  • Update Microsoft.DotNet.Arcade.Sdk from 10.0.0-beta.25523.111 to 11.0.0-beta.25618.104
  • Modernization of build scripts including removing deprecated DOTNET_MULTILEVEL_LOOKUP environment variable, adding -UseBasicParsing to PowerShell web requests, and updating shell script comparisons from legacy > to POSIX-compliant -gt

Reviewed changes

Copilot reviewed 29 out of 55 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
global.json Updates .NET SDK version to 11.0.100-alpha.1.25618.104 and Arcade SDK to 11.0.0-beta.25618.104
eng/Versions.props Updates PrivateSourceBuilt SDK and artifacts versions to 11.0.100-alpha.1.25618.104
eng/Version.Details.xml Updates Arcade SDK dependency metadata with new version and commit SHA
eng/Version.Details.props Updates package version references to 11.0.0-beta.25618.104
eng/common/tools.sh Removes deprecated DOTNET_MULTILEVEL_LOOKUP environment variable
eng/common/tools.ps1 Removes DOTNET_MULTILEVEL_LOOKUP, adds -UseBasicParsing to web requests, updates MSBuild XCopy version to 18.0.0, adds error handling for missing global.json properties
eng/common/sdk-task.ps1 Updates default XCopy MSBuild version to 18.0.0, adds runtime source feed parameters
eng/common/post-build/*.ps1 Adds runtime source feed parameters and -UseBasicParsing flags to web requests
eng/common/native/install-dependencies.sh Adds support for CentOS and Amazon Linux distributions
eng/common/cross/build-rootfs.sh Updates FreeBSD base versions to 13.5-RELEASE and 14.3-RELEASE
eng/common/core-templates/steps/install-microbuild.yml Refactors MicroBuild plugin installation with new parameters and installation directory changes
eng/common/core-templates/steps/install-microbuild-impl.yml New file to support preview and standard MicroBuild plugin installation
eng/common/core-templates/steps/source-index-stage1-publish.yml Updates source index tool versions and changes dotnet tool install flag from --add-source to --source
eng/common/core-templates/steps/generate-sbom.yml Updates SBOM package version from 10.0.0 to 11.0.0
eng/common/core-templates/post-build/post-build.yml Reformats parameter indentation, updates pool images to windows.vs2026preview.scout.amd64, adds internal runtime feed configuration
eng/common/core-templates/job/*.yml Updates pool images and build conditions
eng/common/*.sh Replaces deprecated bash comparison operator > with POSIX-compliant -gt
Various YAML templates Whitespace normalization and indentation fixes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +17 to +18
$(Agent.TempDirectory)/dotnet/dotnet tool install BinLogToSln --version ${{parameters.sourceIndexProcessBinlogPackageVersion}} --source ${{parameters.SourceIndexPackageSource}} --tool-path $(Agent.TempDirectory)/.source-index/tools
$(Agent.TempDirectory)/dotnet/dotnet tool install UploadIndexStage1 --version ${{parameters.sourceIndexUploadPackageVersion}} --source ${{parameters.SourceIndexPackageSource}} --tool-path $(Agent.TempDirectory)/.source-index/tools
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter reference uses incorrect casing. The parameter is defined as sourceIndexPackageSource (line 4) but is referenced as SourceIndexPackageSource (with capital 'S'). This will cause the parameter to be undefined at runtime.

Copilot uses AI. Check for mistakes.
@dotnet-policy-service dotnet-policy-service bot requested a review from a team December 19, 2025 04:42
@ViktorHofer
Copy link
Member

D:\a_work\1\s\src\runtime\eng\targetingpacks.targets(106,5): The shared framework must be built before the local targeting pack can be consumed. [D:\a_work\1\s\src\runtime\src\coreclr\tools\aot\ILCompiler\ILCompiler_publish.csproj]

@hoyosjs / @ericstj / @jkoritzinsky PTAL

@dotnet-policy-service dotnet-policy-service bot requested a review from a team December 19, 2025 17:31
@ericstj
Copy link
Member

ericstj commented Dec 19, 2025

@mmitche -- looks like still a lot of warnings for razor. Will build just that repo locally with latest SDK and fix them all rather than piece-meal after CI finds them (at least I hope to try 🤞)

To build just razor with latest SDK I did the following:

  1. Checkout this branch & cd src\razor
  2. Copy root global.json over top src\razor\global.json
  3. Delete MicrosoftNetCompilersToolsetPackageVersion + MicrosoftNetCompilersToolsetVersion from Version.Details.props
  4. build /bl

@dotnet-policy-service dotnet-policy-service bot requested a review from a team December 19, 2025 19:35
@mmitche
Copy link
Member

mmitche commented Dec 19, 2025

@mmitche -- looks like still a lot of warnings for razor. Will build just that repo locally with latest SDK and fix them all rather than piece-meal after CI finds them (at least I hope to try 🤞)

To build just razor with latest SDK I did the following:

  1. Checkout this branch & cd src\razor
  2. Copy root global.json over top src\razor\global.json
  3. Delete MicrosoftNetCompilersToolsetPackageVersion + MicrosoftNetCompilersToolsetVersion from Version.Details.props
  4. build /bl

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants