Remove infinite timespan reminder checks #9715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2025 11:54
…ot allowed (and to allow for an eventual future change of the InfiniteTimeSpan value)
Contributor
Author
|
@dotnet-policy-service agree |
ReubenBond
approved these changes
Oct 15, 2025
ledjon-behluli
pushed a commit
to ledjon-behluli/orleans
that referenced
this pull request
Oct 26, 2025
* Timeout.InfiniteTimeSpan is not allowed for reminders * Specifically check for InfiniteTimeSpan to make clear it's usage is not allowed (and to allow for an eventual future change of the InfiniteTimeSpan value) --------- Co-authored-by: Jerremy Koot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
* retire and purge state machines * Update src/Orleans.Journaling/StateMachineManager.cs Co-authored-by: Reuben Bond <[email protected]> * move comments up * wip * time-based retirement logic * last touches * remove test project * remove unused usings * prevent duplicate key error during state machine resurrection * ensure buffered data is re-applied if machine comes back * remove hacky assertion in tests * Update src/Orleans.Journaling/StateMachineManager.cs Co-authored-by: Copilot <[email protected]> * Update src/Orleans.Journaling/StateMachineManager.cs Co-authored-by: Copilot <[email protected]> * Update test/Orleans.Journaling.Tests/StateMachineManagerTests.cs Co-authored-by: Copilot <[email protected]> * Update test/Orleans.Journaling.Tests/StateMachineManagerTests.cs Co-authored-by: Copilot <[email protected]> * Update test/Orleans.Journaling.Tests/StateMachineManagerTests.cs Co-authored-by: Copilot <[email protected]> * Fix table creation logging to reflect existing tables correctly (#9696) The `CreateIfNotExistsAsync` method's response will have a 409-statuscode if the table already exists and will always return the `TableItem` if the call is successful. * Fix ZooKeeper CI tests: correct service name and use official Docker image (#9699) * Initial plan * Fix ZooKeeper CI tests: correct service name and use specific image tag Co-authored-by: ReubenBond <[email protected]> * Use official ZooKeeper Docker image instead of bitnami Co-authored-by: ReubenBond <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ReubenBond <[email protected]> * Fix Consul CI tests by using compatible Consul version (#9701) * Fix Consul key format to comply with allowed characters Co-authored-by: ReubenBond <[email protected]> * Use custom encoding for Consul keys instead of URL encoding Co-authored-by: ReubenBond <[email protected]> * Simplify encoding logic to handle both IPv4 and IPv6 Co-authored-by: ReubenBond <[email protected]> * Revert breaking changes and use older Consul version for tests Co-authored-by: ReubenBond <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ReubenBond <[email protected]> * Remove explicit ActivityStatusCode.Ok setting to comply with OpenTelemetry specification (#9703) * Initial plan * Remove explicit ActivityStatusCode.Ok per OpenTelemetry spec Co-authored-by: ReubenBond <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ReubenBond <[email protected]> * chore(deps): bump dotnet-sdk from 9.0.303 to 9.0.305 (#9677) Bumps [dotnet-sdk](https://github.com/dotnet/sdk) from 9.0.303 to 9.0.305. - [Release notes](https://github.com/dotnet/sdk/releases) - [Commits](dotnet/sdk@v9.0.303...v9.0.305) --- updated-dependencies: - dependency-name: dotnet-sdk dependency-version: 9.0.305 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix race condition in `TransactionInfo.Fork` `PendingCalls` increment (#9702) * [FIX] Potential NRE in the activation repartitioner (#9713) fix potentiall NRE in the activation repartioner * Remove infinite timespan reminder checks (#9715) * Timeout.InfiniteTimeSpan is not allowed for reminders * Specifically check for InfiniteTimeSpan to make clear it's usage is not allowed (and to allow for an eventual future change of the InfiniteTimeSpan value) --------- Co-authored-by: Jerremy Koot <[email protected]> * ResponseCompletionSource: RunContinuationsAsynchronously (#9724) * chore(deps): bump dotnet-sdk from 9.0.305 to 9.0.306 (#9720) Bumps [dotnet-sdk](https://github.com/dotnet/sdk) from 9.0.305 to 9.0.306. - [Release notes](https://github.com/dotnet/sdk/releases) - [Commits](dotnet/sdk@v9.0.305...v9.0.306) --- updated-dependencies: - dependency-name: dotnet-sdk dependency-version: 9.0.306 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add `BigInteger` codec (#9669) * StateMachineManager: start work loop during activation (#9725) * Flag PostgreSQL as asynchronous (#9705) Changed isSynchronousAdoNetImplementation from true to false for PostgreSQL thanks to updates in Npgsql 8.0. npgsql/npgsql#1130 * Enable GitHub merge queue (#9727) Enable merge queue * Add missing validation for the NATS stream provider (#9668) Add missing validation for the Nats stream provider * `ActivationDataActivatorProvider`: run grain constructor on grain scheduler (#9726) * ActivationDataActivatorProvider: always run grain constructor on ActivationTaskScheduler * ActivationDataActivatorProvider: always run grain constructor on ActivationTaskScheduler * Modifying Endpoint to use Pascale Casing as EndPoint for consistency (#9671) Co-authored-by: Ramzi Mourtada <[email protected]> * treat retirement tracker as a first-class (internal) machine --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Reuben Bond <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Egil Hansen <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bk <[email protected]> Co-authored-by: Da-Teach <[email protected]> Co-authored-by: Jerremy Koot <[email protected]> Co-authored-by: Gutemberg Ribeiro <[email protected]> Co-authored-by: Burak Büyükatlı <[email protected]> Co-authored-by: Ramzi Mourtada <[email protected]> Co-authored-by: Ramzi Mourtada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source suggests that the usage "InfiniteTimeSpan" is allowed with Reminders, but it is not allowed. As such adding specific checks for InfiniteTimeSpan is more appropriate. The reference to timer.cs has been removed, as it no longer is consistent with the checks from timer.cs.
This resolves issue #9710 .
Microsoft Reviewers: Open in CodeFlow