Revert "Avoid creating a result temp for is-expressions" #69582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e1031a7.
Contributor
|
tagging @alrz so he is aware we're doing this. |
This was referenced Aug 17, 2023
Member
Author
|
Added repro in #69615 and was able to verify that without this revert, we get an NRE when running the compiled code, and once we revert, it starts behaving as expected. |
jaredpar
approved these changes
Aug 18, 2023
alrz
added a commit
to alrz/roslyn
that referenced
this pull request
Mar 7, 2024
…" (dotnet#69582) This reverts commit b4a9c62.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #68694
Suspected of introducing test failures in #69544