Avoid buffering and dispatching all ProducerConsumer items in one go in recent copilot helper. #78454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
May 5, 2025
| return await consumeItems(channel.Reader, args, cancellationToken).ConfigureAwait(false); | ||
| } | ||
|
|
||
| async Task ProduceItemsAndWriteToChannelAsync() |
Member
Author
There was a problem hiding this comment.
the original code in here moved to PerformActionAndCloseWriterAsync so that it could be used by the new helper i added recently.
genlu
reviewed
May 6, 2025
| { | ||
| await Task.Yield().ConfigureAwait(false); | ||
|
|
||
| // It's ok to use TryWrite here. TryWrite always succeeds unless the channel is completed. And the |
genlu
reviewed
May 6, 2025
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/ProducerConsumer.cs
Show resolved
Hide resolved
genlu
approved these changes
May 6, 2025
This was referenced May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.