Rename - fix conversion operator return type #79690
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return underlyingNamedType != null | ||
| ? new([underlyingNamedType]) | ||
| : new([]); | ||
| } |
Member
There was a problem hiding this comment.
i'm not getting the cascadign logic here. Can you clarify why this is needed?
Member
Author
There was a problem hiding this comment.
Yeah, what I was seeing was that only the original symbol (the conversion operator) was getting renamed. Did a test if I tried renaming the class name and saw that it cascaded down to the constructor but there wasn't any similar logic, for the explicit conversion, to cascade up to the return type.
JoeRobich
reviewed
Jul 30, 2025
JoeRobich
reviewed
Jul 30, 2025
Co-authored-by: Joey Robichaud <[email protected]>
Co-authored-by: Joey Robichaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77082