Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Run VirtualProjectXmlProviderTests always now #79708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jasonmalinowski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Run VirtualProjectXmlProviderTests always now #79708

jasonmalinowski wants to merge 1 commit into from

Conversation

@jasonmalinowski
Copy link
Member

@jasonmalinowski jasonmalinowski commented Jul 31, 2025

We're on a new enough SDK that we can assume this will work.

@jasonmalinowski
Run VirtualProjectXmlProviderTests always now
e409792 
We're on a new enough SDK that we can assume this will work.
@jasonmalinowski jasonmalinowski self-assigned this Jul 31, 2025
@jasonmalinowski jasonmalinowski requested a review from a team as a code owner July 31, 2025 19:41
@jasonmalinowski
Copy link
Member Author

jasonmalinowski commented Jul 31, 2025

Looks like the test hung:

The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
The test running when the crash occurred: 
Microsoft.CodeAnalysis.LanguageServer.UnitTests.VirtualProjectXmlProviderTests.GetProjectXml_BadDirective_01

This test may, or may not be the source of the crash.
Results File: work-item-test-results.xml

Attachments:
  C:\h\w\B35009D5\w\AAFC0962\e\2eca7bc4-9822-4e25-ae36-707eaef46e89\Sequence_8f4e6f5bd42e43cdb9880dceb4934a43.xml
  C:\h\w\B35009D5\w\AAFC0962\e\2eca7bc4-9822-4e25-ae36-707eaef46e89\dotnet_444_20250731T204634_hangdump.dmp
  C:\h\w\B35009D5\w\AAFC0962\e\2eca7bc4-9822-4e25-ae36-707eaef46e89\testhost_5028_20250731T204634_hangdump.dmp
  C:\h\w\B35009D5\w\AAFC0962\e\2eca7bc4-9822-4e25-ae36-707eaef46e89\testhost_5028_20250731T204634_hangdump.dmp

@RikkiGibson any known issues here?

@RikkiGibson
Copy link
Member

RikkiGibson commented Jul 31, 2025

I do not know what the issue is, it may be a case of test rot.

So annoying that I need a joined machine now to navigate the test artifacts from the web. I am allowed to download the whole artifact but not list the files in the artifact. So I am unsure where the hang dump was uploaded to.

@dibarbet
Copy link
Member

dibarbet commented Jul 31, 2025

I do not know what the issue is, it may be a case of test rot.

So annoying that I need a joined machine now to navigate the test artifacts from the web. I am allowed to download the whole artifact but not list the files in the artifact. So I am unsure where the hang dump was uploaded to.

@RikkiGibson since these are helix dumps, they would be on the helix test attachments usually. However for some reason the attachments tab on the test is blank. But you can find the dump links on the failed work item details here -
https://helix.dot.net/api/jobs/57b66de2-e0e6-45f0-bc16-c4ac6d99f0b1/workitems/workitem_5?api-version=2019-06-17

@build-analysis build-analysis bot mentioned this pull request Jul 31, 2025
Closed
3 tasks
@RikkiGibson
Copy link
Member

RikkiGibson commented Jul 31, 2025

I'm checking out the branch and trying to run the test now

@RikkiGibson
Copy link
Member

RikkiGibson commented Jul 31, 2025

I ran the tests from Jason's branch but did not repro the failure locally. I downloaded testhost_5028_20250731T204634_hangdump.dmp, but the only Debug action that was available was "Debug with Native Only", which is giving me little/no information about what is going on from .NET point of view.

@RikkiGibson
Copy link
Member

RikkiGibson commented Jul 31, 2025

I wonder if the globalJson being written in each of the enabled tests should be removed. I am hoping that in the absence of it, the repo level globalJson will take effect.

@jasonmalinowski
Copy link
Member Author

jasonmalinowski commented Aug 1, 2025

I too am seeing VS only say there's native code to debug, but WinDBG + !dumpasync was able to find:

0000018c7bc154c8 00007fff519f1780 ( ) System.Threading.Tasks.Task
  0000018c7bc155f8 00007fff5508cd58 (1) System.Diagnostics.Process+<WaitForExitAsync>d__186 @ 7fffbd36b320
    0000018c7bdb3218 00007fff55088230 (2) Microsoft.CodeAnalysis.LanguageServer.FileBasedPrograms.VirtualProjectXmlProvider+<GetVirtualProjectContentImplAsync>d__8 @ 7fff54de83f0
      0000018c7bdb32d0 00007fff55089c70 (0) Microsoft.CodeAnalysis.LanguageServer.FileBasedPrograms.VirtualProjectXmlProvider+<GetVirtualProjectContentAsync>d__7 @ 7fff54de6990
        0000018c78f9d3c0 00007fff5298ad20 (3) Microsoft.CodeAnalysis.LanguageServer.UnitTests.VirtualProjectXmlProviderTests+<GetProjectXml_BadDirective_01>d__6 @ 7fff526ea540
          0000018c78f9d4c0 00007fff5298c558 (0) Xunit.Sdk.TestInvoker<Xunit.Sdk.IXunitTestCase>+<>c__DisplayClass47_0+<<InvokeTestMethodAsync>b__1>d @ 7fff526e96e0

So looks like we have a deadlock or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

@dibarbet dibarbet dibarbet approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@jasonmalinowski jasonmalinowski

@RikkiGibson RikkiGibson

Labels

Area-IDE VSCode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasonmalinowski @RikkiGibson @dibarbet @JoeRobich