Better codegen for record's Equals member
#79966
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes in synthesized records' `Equals` methods
jaredpar
requested changes
Aug 21, 2025
Member
jaredpar
left a comment
There was a problem hiding this comment.
Putting a hold on the PR until the underlying issue gets LDM sign off.
Contributor
Author
|
@jaredpar Do you have this question scheduled for an LDM? Correct me if I am wrong, but this is a weekly event, isn't it? I don't think it would take much discussion time to make a decision here |
Member
Usually but not always.
No. Don't believe anyone has put this on the agenda. @RikkiGibson, @CyrusNajmabadi in case they have time to bring this in the next few weeks. |
Member
|
I'll look into it. I don't find it hugely important. But if we have time, then sure:-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70221
One of comments in the issue also mentions
GetHashCode. I tried it locally (by "it" I mean callingGetHashCodedirectly when overriden in structs) and it turns out that it takes a bit more IL due to ceremony with constrained call, so I didn't include those changes