Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't report assignment to ref extension parameter as unused #81680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcouv merged 2 commits into from
Dec 16, 2025
Merged

Don't report assignment to ref extension parameter as unused #81680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86ae893
Don't report assignment to ref extension parameter as unused
Dec 12, 2025
264b35b
Address feedback
Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ...nalyzers/CSharp/Tests/RemoveUnusedParametersAndValues/RemoveUnusedValueAssignmentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9369,6 +9369,29 @@ private static void M(ref int destinationIndex, S buffer)
ReferenceAssemblies = ReferenceAssemblies.Net.Net80,
}.RunAsync();

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/81554")]
public Task TestWriteIntoExtensionRefReceiver()
=> new VerifyCS.Test
{
TestCode = """
public static class E
{
extension(ref double number)
{
public void M(double max)
{
number = max;
}
}
}
""",
LanguageVersion = LanguageVersion.CSharp14,
Options =
{
{ CSharpCodeStyleOptions.UnusedValueAssignment, UnusedValuePreference.DiscardVariable, NotificationOption2.Suggestion },
},
}.RunAsync();

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/77258")]
public Task TestWriteIntoStructIndexer()
=> new VerifyCS.Test
Expand Down
18 changes: 17 additions & 1 deletion ...nalysis/SymbolUsageAnalysis/SymbolUsageAnalysis.DataFlowAnalyzer.FlowGraphAnalysisData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ public static FlowGraphAnalysisData Create(
{
Debug.Assert(cfg.Parent == null);

var parameters = owningSymbol.GetParameters();
var parameters = GetParameters(owningSymbol);

return new FlowGraphAnalysisData(
cfg,
owningSymbol,
Expand All @@ -134,6 +135,21 @@ public static FlowGraphAnalysisData Create(
reachingDelegateCreationTargets: PooledDictionary<IOperation, PooledHashSet<IOperation>>.GetInstance(),
localFunctionTargetsToAccessingCfgMap: PooledDictionary<IMethodSymbol, ControlFlowGraph>.GetInstance(),
lambdaTargetsToAccessingCfgMap: PooledDictionary<IFlowAnonymousFunctionOperation, ControlFlowGraph>.GetInstance());

static ImmutableArray<IParameterSymbol> GetParameters(ISymbol owningSymbol)
{
var parameters = owningSymbol.GetParameters();
#if !ROSLYN_4_12_OR_LOWER
if (owningSymbol.ContainingSymbol is INamedTypeSymbol { IsExtension: true, ExtensionParameter: { } extensionParameter })
{
return parameters.Add(extensionParameter); // order doesn't matter
}

return parameters;
#else
return parameters;
#endif
Comment on lines 141 to 151
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var parameters = owningSymbol.GetParameters();
#if ROSLYN_4_12_OR_LOWER
return parameters;
#else
if (owningSymbol.ContainingSymbol is INamedTypeSymbol { IsExtension: true, ExtensionParameter: { } extensionParameter })
{
return parameters.Insert(0, extensionParameter);
}
return parameters;
#endif
var parameters = owningSymbol.GetParameters();
#if !ROSLYN_4_12_OR_LOWER
if (owningSymbol.ContainingSymbol is INamedTypeSymbol { IsExtension: true, ExtensionParameter: { } extensionParameter })
{
return parameters.Insert(0, extensionParameter);
}
#else
return parameters;
#endif

}
}

public static FlowGraphAnalysisData Create(
Expand Down
Loading