Unsafe evolution: check lang version for caller-unsafe declarations #81698
+132
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Dec 15, 2025
| }) | ||
| .VerifyDiagnostics(); | ||
|
|
||
| CompileAndVerify(source, |
Member
There was a problem hiding this comment.
Please use an explicit langversion option here for clarity. #Closed
333fred
approved these changes
Dec 16, 2025
Member
Author
|
@jcouv for a second review, thanks |
Member
Author
|
@AlekseyTs for a second review if you are available, thanks |
jcouv
reviewed
Dec 18, 2025
| return members; | ||
| } | ||
|
|
||
| public static ImmutableArray<Symbol> GetMembersByQualifiedName(this NamespaceOrTypeSymbol container, string qualifiedName) |
Member
There was a problem hiding this comment.
nit: consider making this GetMembersByQualifiedName<T> like GetMembers<T> above. Then the caller doesn't need OfType<MethodSymbol> (unless there were multiple member kinds involved)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #81207
Follow up on #81581 (i.e., still only for methods and properties).