Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify some analyzer code. #81760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CyrusNajmabadi wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −30
Open

Simplify some analyzer code. #81760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6952780
Simplify code
CyrusNajmabadi Dec 19, 2025
9f1380f
Simplify code
CyrusNajmabadi Dec 19, 2025
5f61ea5
Simplify code
CyrusNajmabadi Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions ...yzers/Core/Analyzers/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,21 +557,14 @@ private void AnalyzeInvocationOperation(OperationAnalysisContext operationContex

// If the invoked method is a reduced extension method, also mark the original
// method from which it was reduced as "used".
if (targetMethod.ReducedFrom != null)
OnSymbolUsage(targetMethod.ReducedFrom, ValueUsageInfo.Read);
OnSymbolUsage(targetMethod.ReducedFrom, ValueUsageInfo.Read);

// If the invoked method is an implementation method for an extension member,
// also mark that extension member as "used".
// If the extension member is an accessor, also mark its associated property as "used".
if (targetMethod.TryGetCorrespondingExtensionBlockMethod() is { } extensionBlockMethod)
{
OnSymbolUsage(extensionBlockMethod, ValueUsageInfo.Read);

if (extensionBlockMethod.AssociatedSymbol is { } associatedSymbol)
{
OnSymbolUsage(associatedSymbol, ValueUsageInfo.Read);
}
}
var extensionBlockMethod = targetMethod.TryGetCorrespondingExtensionBlockMethod();
OnSymbolUsage(extensionBlockMethod, ValueUsageInfo.Read);
OnSymbolUsage(extensionBlockMethod?.AssociatedSymbol, ValueUsageInfo.Read);
}

private void AnalyzeNameOfOperation(OperationAnalysisContext operationContext)
Expand Down Expand Up @@ -820,11 +813,11 @@ private void AddCandidateSymbolsReferencedInDocComments(

AddIfCandidateSymbol(builder, symbol);

if (symbol is IMethodSymbol methodSymbol
&& methodSymbol.TryGetCorrespondingExtensionBlockMethod() is { } extensionBlockMethod)
if (symbol is IMethodSymbol methodSymbol)
{
var extensionBlockMethod = methodSymbol.TryGetCorrespondingExtensionBlockMethod();
AddIfCandidateSymbol(builder, extensionBlockMethod);
AddIfCandidateSymbol(builder, extensionBlockMethod.AssociatedSymbol);
AddIfCandidateSymbol(builder, extensionBlockMethod?.AssociatedSymbol);
}
}
}
Expand Down
29 changes: 13 additions & 16 deletions ...paces/SharedUtilitiesAndExtensions/Compiler/Extensions/Symbols/IMethodSymbolExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,26 +18,23 @@ internal static partial class IMethodSymbolExtensions
#if !ROSLYN_4_12_OR_LOWER
internal static IMethodSymbol? TryGetCorrespondingExtensionBlockMethod(this IMethodSymbol methodSymbol)
{
if (methodSymbol is not { IsStatic: true, IsImplicitlyDeclared: true, ContainingType.MightContainExtensionMethods: true })
return null;

// Having a compiler API to go from implementation method back to its corresponding extension member would be useful
// Tracked by https://github.com/dotnet/roslyn/issues/81686

foreach (var nestedType in methodSymbol.ContainingType.GetTypeMembers())
if (methodSymbol is { IsStatic: true, IsImplicitlyDeclared: true, ContainingType.MightContainExtensionMethods: true })
{
if (!nestedType.IsExtension || nestedType.ExtensionParameter is null)
continue;
// Having a compiler API to go from implementation method back to its corresponding extension member would be useful
// Tracked by https://github.com/dotnet/roslyn/issues/81686

foreach (var member in nestedType.GetMembers())
foreach (var nestedType in methodSymbol.ContainingType.GetTypeMembers())
{
if (member is IMethodSymbol method)
{
var associated = method.AssociatedExtensionImplementation;
if (!Equals(associated, methodSymbol))
continue;
if (!nestedType.IsExtension || nestedType.ExtensionParameter is null)
continue;

return method;
foreach (var member in nestedType.GetMembers())
{
if (member is IMethodSymbol method &&
Equals(method.AssociatedExtensionImplementation, methodSymbol))
{
return method;
}
}
}
}
Expand Down
Loading