Fix crash in Rename adornment with vertical document groups #81717
+26
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
requested changes
Dec 16, 2025
src/EditorFeatures/Core/InlineRename/UI/Adornment/RenameFlyout.xaml.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core/InlineRename/UI/Adornment/RenameFlyout.xaml.cs
Outdated
Show resolved
Hide resolved
Member
|
I'm also confused by this comment:
...that shouldn't be possible. We should be committing the prior one before the new one starts. Did we break that? |
Contributor
Author
|
Agreed, your concern is valid. InlineRenameSession should prevent simultaneous rename operations, so the original scenario describing “multiple rename operations in vertical document groups” may not be accurate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #81716
Adds error handling to RenameFlyout.PositionAdornment() to prevent crashes