Cleanup Mono heplers #29533
Merged
Cleanup Mono heplers #29533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the Mono helpers: 1. Properly don't run verification on Mono. Only Windows Desktop runs verification at this time 1. Use the CoreClr ilasm utility instead of the Mono version. It has the functionality we need for our unit tests.
Member
Author
|
CC @dotnet/roslyn-compiler for review |
Member
Author
|
retest ubuntu_16_mono_debug_prtest please |
Member
Author
|
mono exited with a SIGABT. Want to see if that's a one off or a reliably reproducing bug. |
Member
Author
|
Looks like this is pretty consistently causing Mono to SIGABRT here. Going to block this for now and file a bug against Mono for investigation. |
Member
|
Marked as "for personal review" so it doesn't show up in the query while it's blocked. |
Member
Author
|
CC @jcouv after digging a bit I found the test that was causing Mono issues, disabled it and everything is passing now. Can you re-review the small diff that applied? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Mono helpers:
verification at this time
functionality we need for our unit tests.
Related #28011