Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add unlock functionality for reopened issues and PRs in locker workflow #119003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 4 commits into from
Dec 11, 2025
Merged

Add unlock functionality for reopened issues and PRs in locker workflow #119003

akoeplinger merged 4 commits into from
Dec 11, 2025

Conversation

Copy link
Contributor

Copilot AI commented Aug 22, 2025 •
edited
Loading

This PR enhances the .github/workflows/locker.yml workflow to automatically unlock issues and pull requests when they are reopened, addressing the need to make previously locked items accessible again when discussion resumes.

Changes Made

New Event Triggers

  • Added issues.reopened trigger to detect when closed issues are reopened
  • Added pull_request_target.reopened trigger to detect when closed PRs are reopened

Enhanced Job Logic

  • Lock job (renamed from main for clarity):

    • Added condition to prevent execution on reopened events: github.event_name != 'issues' && github.event_name != 'pull_request_target'
    • Preserves existing functionality for scheduled runs and manual dispatch

  • New unlock job:

    • Only executes when issues or PRs are reopened: github.event.action == 'reopened'
    • Uses actions/github-script@v7 with GitHub REST API to unlock items
    • Handles both issues and pull requests with a single step (since GitHub treats PRs as issues in the API)
    • Only unlocks if the item is actually locked: github.event.issue.locked == true

Workflow Behavior

  • Before: Issues/PRs remained locked after being reopened, preventing further discussion
  • After: Issues/PRs are automatically unlocked when reopened, allowing immediate participation

Technical Implementation

The unlock functionality uses the GitHub Issues API (which also handles PRs) through actions/github-script@v7:

await github.rest.issues.unlock({
  issue_number: context.issue.number,
  owner: context.repo.owner,
  repo: context.repo.repo,
});

This ensures that when maintainers or contributors reopen issues or PRs for continued discussion, they won't encounter locked conversation threads that prevent community engagement.

Fixes the workflow gap where reopened items remained inaccessible for comments despite being active again.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 22, 2025
Copilot AI changed the title [WIP] change .github/workflows/locker.yml so that it unlocks an issue or pr when it is reopened. make sure we don't run the existing job which locks issues in that case Add unlock functionality for reopened issues and PRs in locker workflow Aug 22, 2025
Copilot AI requested a review from akoeplinger August 22, 2025 14:59
@akoeplinger
Copy link
Member

akoeplinger commented Aug 22, 2025

@copilot you don't need to have a separate step for pull requests since they're treated as issues by GitHub already.

Use code like this to unlock the pr/issue:

    - name: Unlock if issue/PR is locked
      uses: actions/github-script@v7
      if: ${{ github.event.issue.locked == true }}
      with:
        script: |
          console.log(`Unlocking locked issue/PR #${context.issue.number}.`);
          await github.rest.issues.unlock({
            issue_number: context.issue.number,
            owner: context.repo.owner,
            repo: context.repo.repo,
          });

@akoeplinger
Copy link
Member

akoeplinger commented Aug 22, 2025

@copilot oh and use the pull_request_target event

Copy link
Contributor Author

Copilot AI commented Aug 22, 2025

@copilot oh and use the pull_request_target event

Updated the workflow to use pull_request_target event and consolidated the unlock logic using actions/github-script@v7 with the locked condition check as suggested. The implementation now uses a single step that works for both issues and PRs since GitHub treats them the same in the API. (8e5c754)

@akoeplinger akoeplinger marked this pull request as ready for review August 22, 2025 16:15
Copilot AI review requested due to automatic review settings August 22, 2025 16:15
@akoeplinger akoeplinger requested review from a team and jeffhandley as code owners August 22, 2025 16:15
@akoeplinger
Copy link
Member

akoeplinger commented Aug 22, 2025

/ba-g only change to a GitHub Action so no AzDO builds got triggered

Copilot AI reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the GitHub Actions locker workflow to automatically unlock issues and pull requests when they are reopened, ensuring that previously locked conversations become accessible again when discussion resumes.

Key changes:

  • Added event triggers for issues.reopened and pull_request_target.reopened
  • Split workflow into separate lock and unlock jobs with appropriate conditions
  • Implemented unlock functionality using GitHub REST API

@akoeplinger
Copy link
Member

akoeplinger commented Aug 22, 2025

/ba-g only change to a GitHub Action so no AzDO builds got triggered

@akoeplinger akoeplinger added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 22, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Aug 22, 2025

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 21, 2025

@jeffhandley FYI that we will have a workflow that unlocks reopened issues and PRs for external contributors. Does this look right to you?

@akoeplinger akoeplinger merged commit 0b723b3 into main Dec 11, 2025
16 of 17 checks passed
@akoeplinger akoeplinger deleted the copilot/fix-e991656e-f95a-496b-8728-d7c86f5803b5 branch December 11, 2025 11:47
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 13, 2025
Merged
jeffhandley
jeffhandley reviewed Dec 31, 2025
View reviewed changes
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suuuuuper late to review, but yes this looks good, @ViktorHofer; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffhandley jeffhandley jeffhandley left review comments

Copilot code review Copilot Copilot left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

+1 more reviewer

@akoeplinger akoeplinger akoeplinger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@akoeplinger akoeplinger

Copilot code review Copilot

Labels

area-Infrastructure

Projects

Runtime Infra
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akoeplinger @ViktorHofer @jeffhandley