Fix TryEnsureSufficientExecutionStack with interpreter #122248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ReflectionInvocation::TryEnsureSufficientExecutionStack was not taking into account the fact that with interpreter enabled, the code can be executed either by the interpreter or it can be AOTed. The interpreter has its own stack with its own limit. 3 libraries tests suites were failing due to this problem. As a best effort fix, this change adds check for the interpreter stack too and the method returns true only if there is enough space on both real and the interpreter stack, as it is not possible to decide which of them will be used.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in TryEnsureSufficientExecutionStack where the interpreter's stack was not being checked. The method now correctly checks both the native stack and the interpreter stack when the interpreter is enabled, ensuring that code execution has sufficient stack space regardless of whether it's executed by the interpreter or AOT-compiled code.
Key Changes:
- Added interpreter stack checking alongside existing native stack checking
- Uses the same minimum stack size thresholds as the native stack (128KB on 64-bit, 64KB on 32-bit)
- Returns true only when both stacks have sufficient space
davidwrighton
approved these changes
Dec 5, 2025
This was referenced Dec 6, 2025
Open
BrzVlad
approved these changes
Dec 7, 2025
Member
Author
|
/ba-g the issues are unrelated to the change |
This was referenced Dec 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReflectionInvocation::TryEnsureSufficientExecutionStack was not taking into account the fact that with interpreter enabled, the code can be executed either by the interpreter or it can be AOTed. The interpreter has its own stack with its own limit.
3 libraries tests suites were failing due to this problem.
As a best effort fix, this change adds check for the interpreter stack too and the method returns true only if there is enough space on both real and the interpreter stack, as it is not possible to decide which of them will be used.