[clr-interp] ckfinite throws wrong exception. #122365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that RyuJit throws OverflowException here, not ArithmeticException. This is contrary to the ECMA spec, but lets not introduce an unnecessary difference here.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an inconsistency in exception handling for the ckfinite IL operation in the CoreCLR interpreter. The ckfinite instruction throws OverflowException when encountering infinite or NaN values in RyuJIT, but the interpreter was incorrectly throwing ArithmeticException. This change aligns the interpreter behavior with RyuJIT.
- Changed exception type from
ArithmeticExceptiontoOverflowExceptionfor floating-point finite checks - Applied consistently to both float and double overloads of
CkfiniteHelper
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
This was referenced Dec 10, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that RyuJit throws OverflowException here, not ArithmeticException. This isn't against the ECMA spec since OverflowException derives from ArithmeticException, so lets just follow Ryujit's lead.