Update HybridGlobalization error messages to remove obsolete guidance #122645
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 6 error messages in Strings.resx that incorrectly told users to "Disable it to load larger ICU bundle" when HybridGlobalization=true. Since hybrid globalization can no longer be disabled on Apple mobile platforms, the messages now direct users to adjust their code or open an issue on https://github.com/dotnet/runtime. Co-authored-by: matouskozak <[email protected]>
Copilot
AI
changed the title
[WIP] Remove hybrid globalization references from Strings.resx
Update HybridGlobalization error messages to remove obsolete guidance
Dec 18, 2025
matouskozak
reviewed
Dec 18, 2025
src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
… messages Per review feedback, changed error messages to use clearer platform-specific language "on Apple mobile platforms" instead of "when HybridGlobalization=true on this platform". Co-authored-by: matouskozak <[email protected]>
matouskozak
approved these changes
Dec 18, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Updates HybridGlobalization-related error messages in Strings.resx to reflect current platform constraints. The key change is removing guidance to disable HybridGlobalization (which is no longer possible on Apple mobile platforms) and directing users to adjust their code or report issues on GitHub instead.
- Replaces obsolete "Disable it to load larger ICU bundle" guidance with actionable advice
- Updates platform references from "when HybridGlobalization=true on this platform" to clearer "on Apple mobile platforms"
- Directs users to https://github.com/dotnet/runtime for reporting issues
| </data> | ||
| <data name="PlatformNotSupported_HybridGlobalizationWithCompareOptions" xml:space="preserve"> | ||
| <value>CompareOptions = {0} are not supported when HybridGlobalization=true on this platform. Disable it to load larger ICU bundle, then use this option.</value> | ||
| <value>CompareOptions = {0} are not supported on Apple mobile platforms. Adjust your code or open an issue on https://github.com/dotnet/runtime if this is impacting your use case.</value> |
There was a problem hiding this comment.
Grammar issue: "CompareOptions = {0} are not supported" should use "is" instead of "are" since CompareOptions is a singular entity being compared to a value.
| </data> | ||
| <data name="PlatformNotSupported_HybridGlobalizationWithCompareOptionsForCulture" xml:space="preserve"> | ||
| <value>CompareOptions = {0} are not supported for culture = {1} when HybridGlobalization=true on this platform. Disable it to load larger ICU bundle, then use this option.</value> | ||
| <value>CompareOptions = {0} are not supported for culture = {1} on Apple mobile platforms. Adjust your code or open an issue on https://github.com/dotnet/runtime if this is impacting your use case.</value> |
There was a problem hiding this comment.
Grammar issue: "CompareOptions = {0} are not supported" should use "is" instead of "are" since CompareOptions is a singular entity being compared to a value.
3 tasks
jkotas
reviewed
Dec 18, 2025
| </data> | ||
| <data name="PlatformNotSupported_HybridGlobalizationWithCompareOptions" xml:space="preserve"> | ||
| <value>CompareOptions = {0} are not supported when HybridGlobalization=true on this platform. Disable it to load larger ICU bundle, then use this option.</value> | ||
| <value>CompareOptions = {0} are not supported on Apple mobile platforms. Adjust your code or open an issue on https://github.com/dotnet/runtime if this is impacting your use case.</value> |
Member
There was a problem hiding this comment.
Suggested change
| <value>CompareOptions = {0} are not supported on Apple mobile platforms. Adjust your code or open an issue on https://github.com/dotnet/runtime if this is impacting your use case.</value> | |
| <value>CompareOptions = {0} are not supported on Apple mobile platforms.</value> |
I think this is sufficient. I do not think we have any other error message where we explicitly tell people to open issue in dotnet/runtime.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main PR
Description
HybridGlobalization error messages in
Strings.resxincorrectly told users to "Disable it to load larger ICU bundle" — but hybrid globalization can no longer be disabled on Apple mobile platforms.Updated 6 error messages to:
Affected messages:
PlatformNotSupported_HybridGlobalizationWithCompareOptionsPlatformNotSupported_HybridGlobalizationWithMixedCompositionsPlatformNotSupported_HybridGlobalizationWithCompareOptionsForCulturePlatformNotSupported_HybridGlobalizationWithMatchLengthPlatformNotSupported_HybridGlobalizationPlatformNotSupportedWithReason_HybridGlobalizationCustomer Impact
Users hitting these exceptions receive incorrect guidance suggesting a configuration option that no longer exists.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.