Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[wasm][coreclr] Do not try to probe .ni.dll assemblies #122643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
radekdoulik wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[wasm][coreclr] Do not try to probe .ni.dll assemblies #122643

radekdoulik wants to merge 1 commit into from
+8 −2

Conversation

@radekdoulik
Copy link
Member

@radekdoulik radekdoulik commented Dec 18, 2025 •
edited
Loading

To not slow down startup on wasm platforms.

Copilot AI review requested due to automatic review settings December 18, 2025 14:41
@radekdoulik radekdoulik marked this pull request as draft December 18, 2025 14:42
@radekdoulik radekdoulik added this to the Future milestone Dec 18, 2025
Copilot AI reviewed Dec 18, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes assembly loading for WebAssembly by removing native image (.ni.dll) probing, which is no longer supported on WASM and can negatively impact startup performance. The change affects only the CoreCLR binder's assembly probing logic.

Key Changes

  • Conditionally excludes .ni.dll from assembly probe candidates when targeting WASM
  • Updates loop iteration to use ARRAY_SIZE macro instead of hardcoded value for better maintainability

@radekdoulik
Copy link
Member Author

radekdoulik commented Dec 18, 2025 •
edited
Loading

@jkotas there's still many places related to .ni.dll.

> git grep ni.dll | wc -l  
      45

Would it be worth to remove .ni.dll support in the whole repo?

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Dec 18, 2025

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@vitek-karas
Copy link
Member

vitek-karas commented Dec 18, 2025

@grendello was looking into something similar for Android (we don't need/want it there either)... and I assume we would like that for iOS as well.
I know that there was a discussion if we should just remove this functionality from the runtime everywhere (personally I've never seen an app which would use this).

@jkotas
Copy link
Member

jkotas commented Dec 18, 2025

Would it be worth to remove .ni.dll support in the whole repo?

Yes, I went over the grep output and it looks all dead code, outdated comments, or local workaround for compat (PdbWriter.cs, CallChainProfile.cs, DumpModel.cs - these should be kept). Can you give it a shot to clean up the rest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@radekdoulik radekdoulik

Labels

area-AssemblyLoader-coreclr

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

3 participants

@radekdoulik @vitek-karas @jkotas