-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add GitHub Action workflow to update man pages #48784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| done | ||
|
|
||
| # rm -rf docs-main | ||
| rm -rf docs-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a sub-repo (or a subdirectory) that we never want to git add.
| run: | | ||
| set -euo pipefail | ||
| rm ./documentation/manpages/sdk/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting everything allows stale pages to be removed.
|
Sample run: https://github.com/omajid/dotnet-sdk/actions/runs/14765764022 PR that it opened: omajid#3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments. Making a workflow out of this makes perfect sense to me, I just have a few questions I'm asking internally about permissions/security.
|
I chatted with some folks internally and they've ok'd it. Let's get the email/username thing updated and get this in! |
|
I am curious. Does this target changes to |
The docs say that |
This repo contains man pages. They are generated from another repo, and need to be updated manually. Generally, someone updates them once a year or so, and often it's too late for GA: - dotnet#36447 - dotnet#29032 So automate the update using GitHub Actions.
- Use better name/email for git commit - More details in the PR
22260ed to
f54b3b2
Compare
|
Thanks, @baronfel ! PR is good to go from my side. |
Oh great thanks, wasn't sure about that :) |
|
Thanks for the contribution. Good idea to automate this more. |
This repo contains man pages. They are generated from another repo, and need to be updated manually. Generally, someone updates them once a year or so, and often it's too late for GA:
So automate the update using GitHub Actions.