prompt for password if none is given #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluetzner
commented
Aug 1, 2024
Contributor
Author
rluetzner
left a comment
There was a problem hiding this comment.
Because I'm reeeeeeeally new to Rust (apart from the changes yesterday, this is my first time working with Rust), I have a few questions and comments already.
drdo
reviewed
Aug 1, 2024
This shows a password prompt, if neither the `--password-file` or `--password-command` option is given **and** the `RESTIC_PASSWORD` env variable is unset. There's no way to hand over the password to restic as a CLI parameter, so we use the `RESTIC_PASSWORD` env variable under the hood to set it instead. The env variable is only valid for the restic process we call internally, so the next time redu is run, it'll prompt for the password again.
Contributor
Author
|
Tested the new code and |
Owner
|
Great job! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows a password prompt, if neither the
--password-fileor--password-commandoption is given and theRESTIC_PASSWORDenv variable is unset.There's no way to hand over the password to restic as a CLI parameter, so we use the
RESTIC_PASSWORDenv variable under the hood to set it instead. The env variable is only valid for the restic process we call internally, so the next time redu is run, it'll prompt for the password again.This fixes #27 .