CI is failing because I can't even go dep. I've never used it before and I can't get it to work. Some pointers would be appreciated, please

I worked it out: I was using outdated vendored packages locally, which explains why it only failed in CI on fresh pull

I have reworked the way that this destroys old servers, hence the repeated changes, but I think the logic is simple and stable now

You should not panic at all.

I agree. I was being consistent with other drivers in this case. Given the function signature doesn't handle errors, what else could/should I do?

IMHO you should check that within the New func and error out.

Option errors are checked and handled gracefully now

this looks good to me, just needs to be updated to use go modules. Also when we merge, if you don't mind, submit an entry to configure for Scaleway at https://github.com/drone/autoscaler-docs :)

Looks like your choosen default values aren't that great, the autoscaler always fails for C1 and ARM64-2GB instances, local boot mode is not possible.

The image/size combo is a bit complicated. As default it should work with amd64. You have to change the image if you change the arch, location or size

Looks like I got to create a PR to fix the options, https://github.com/drone/autoscaler/blob/master/drivers/scaleway/create.go#L35 this hard-coded value doesn't work for the arm32/arm64 images. I don't need scaleway for amd64 nodes, I need it only for arm32/arm64.

while we're on the topic, it would be great to have some docs for Scaleway at https://github.com/drone/autoscaler-docs 😄

#55 will fix my issues with the Scaleway implementation, after that I can prepare a PR that documents this provider.

I started a branch for documenting this, but I haven't had time to finish it. You're welcome to use it as a base
frebib/autoscaler-docs@858d6bc

Hi !
@frebib Nice feature to have the Scaleway implementation, thanks.
But the docs aren't merged yet.
What is missing in your documentation ? So we can complete it and PR it ?