Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(llm/gemini): store and forward encrypted_content #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

feat(llm/gemini): store and forward encrypted_content #198

merged 1 commit into from
Sep 16, 2025

Conversation

@dstoc
Copy link
Owner

@dstoc dstoc commented Sep 16, 2025

No description provided.

@dstoc dstoc force-pushed the dstoc/gemini-thought-signature branch from 83e3967 to f9ad183 Compare September 16, 2025 03:27
@dstoc
Copy link
Owner Author

dstoc commented Sep 16, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Script failed: Script exited with code 101
About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@dstoc
Copy link
Owner Author

dstoc commented Sep 16, 2025

@codex reiew

@chatgpt-codex-connector
Copy link

Summary

  • The patch updates AssistantPart to carry optional encrypted_content and adjusts ResponseChunk to stream those parts so Gemini can round-trip provider signatures across requests. crates/llm/src/lib.rsL26-L133

Blocking Issues

  1. In GeminiRustClient::send_chat_messages_stream, the streaming adapter only emits thinking/text parts when text is non-empty. Gemini returns encrypted segments with text == "" but a populated thought_signature; dropping those chunks means we never persist (or forward) the encrypted payload the PR set out to preserve. Please emit an AssistantPart whenever encrypted_content is present, even if the visible text is empty. crates/llm/src/gemini_rust.rsL176-L195

Testing

  • ✅ cargo check

View task →

@dstoc dstoc force-pushed the dstoc/gemini-thought-signature branch from f9ad183 to 6a19db3 Compare September 16, 2025 04:18
@dstoc dstoc enabled auto-merge (rebase) September 16, 2025 04:19
@dstoc dstoc merged commit f04c6fb into main Sep 16, 2025
1 check passed
@dstoc dstoc deleted the dstoc/gemini-thought-signature branch September 16, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dstoc