Use server-managed user SSH keys for new runs #3216
Merged
+242
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the CLI and the server to use
server-managed user SSH keys when starting new
runs. This allows users to attach to the run from
different machines, since the SSH key is
automatically replicated to all clients.
Implementation details:
- Server:
- If the user key is missing, generate it when
the user first calls `/get_my_user`.
- Client:
- Before applying or getting a run plan, call
`/get_my_user` to check if the user key is
available. If it is, use it.
- Cache the downloaded keys in `~/.dstack/ssh`
to avoid repeated `/get_my_user` calls.
- Switch from `warn` to logger messages, since
this code is part of the Python API, so its
output should be configurable.
r4victor
reviewed
Oct 23, 2025
| from dstack._internal.core.models.users import UserWithCreds | ||
|
|
||
| if TYPE_CHECKING: | ||
| from dstack.api.server import APIClient |
There was a problem hiding this comment.
Why put UserSSHKeyManager in core instead of api?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the CLI and the server to use
server-managed user SSH keys when starting new
runs. This allows users to attach to the run from
different machines, since the SSH key is
automatically replicated to all clients.
Implementation details:
/get_my_user./get_my_userto check if the user key is available. If it is, use it.~/.dstack/sshto avoid repeated/get_my_usercalls.warnto logger messages, since this code is part of the Python API, so its output should be configurable.Closes #3199