See also pytorch/pytorch#89064

Tell me when you want to merge

Thanks @mariogeiger --- ideally just want to see the tests pass, and if anyone else wants to take a quick look to make sure I didn't make any typos / logical errors in this, since it touches some of the compilation logic that underpins most of the library.

Looks good from my side. Thanks for cleaning up the Torch2 stuff

There is a problem with the tests

Why does this file exist? https://github.com/e3nn/e3nn/blob/main/examples/conftest.py
It seems like a duplicate of the one in tests/...

No idea, does it help it you delete it?

Let's find out 😄

I suspect it's due to a combination of that file and the fact that the GitHub actions are set up run any tests anywhere in the repo:
https://github.com/e3nn/e3nn/blob/main/.github/workflows/tests.yml#L56

instead of only in the tests/ folder. Is that intentional?

(Either way seem to be running fine now)

I remember the examples were failing because of torch-cluster, torch-sparse… import issues when I was testing locally.

Hopefully this also fixed that

Update: Yup it did !

For the Torch 2 test that is failing its running alright locally when I do

pytest --doctest-modules --ignore=docs/ tests/o3/experimental/test_fulltp.py

so not sure what's happening there

Is there a way to just not run tests or flake8 on anything in experimental right now?

Either way, it does look like all failures are unrelated to this PR, so I think we're good to merge, thanks!

Do you mind doing a --ignore=tests/o3/experimental or should I put it another PR ?

Ok let me merge and feel free to make another PR to fix this test problem

Great, thanks guys!