Updated file path extraction code to use only QGIS methods #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code replaces the code that I wrote to manually extract a layer's path from its URI with code that uses the QGIS API to do the path extraction and decoding. I think using only the QGIS API with no fallback is fine since that is what QGIS and the providers use themselves.
The code has some extra logging statements that are only intended for testing, these are prefixed with
TBR:("To Be Removed"). If the code looks good to you then I'll push an update that does not have these logging statements.The code has been actively and passively tested on Linux and Windows (including behavior with unsupported layer types, e.g. ArcGIS REST layers) and no issues were observed.
Fixes #7 and #8